mirror of
https://github.com/aome510/spotify-player.git
synced 2026-04-26 09:25:49 +03:00
[GH-ISSUE #278] Adjustable column size #1079
Labels
No labels
bug
documentation
enhancement
good first issue
help wanted
pull-request
question
third-party
third-party
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-player#1079
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cyberfeign on GitHub (Oct 26, 2023).
Original GitHub issue: https://github.com/aome510/spotify-player/issues/278
Is your feature request related to a problem? Please describe.
I use this awesome client in a Tmux pane on a custom panel with other applications where space is rather scarce. I've noticed that for instance track duration is sometimes clipped when dimensions are reduced.
Describe the solution you'd like
I'd like to be able to configure the width/number of characters per column (independently?) in browse view etc. so that I can adjust space according to preference and avoid content outside viewable area.
Describe alternatives you've considered
Perhaps also adjusted settings for automatic column condensation depending on content and window size. Certain columns sometimes have unused space while other columns are too narrow or outside window area.
@aome510 commented on GitHub (Oct 27, 2023):
The clipped
durationcolumn seems to be because not all columns in the track table are constructed using percentage constraints:github.com/aome510/spotify-player@3b2a36625a/spotify_player/src/ui/page.rs (L743-L750)Edit: even if all columns are constructed using percentage constraints, the clipping still happens.
Regarding the adjustable column size, do you mean able to configure the percentage of each column? For example,
@Autobeing commented on GitHub (Oct 28, 2023):
Precisely, something like that is what I would do. Percentages would make it easy to understand, with a clear default value as well.
@cyberfeign commented on GitHub (Oct 28, 2023):
Yep, that looks good. Odd that it's still clipping, maybe due to how the width of the window is set?
@sewnie commented on GitHub (Nov 10, 2023):
Please! this damn padding at the bottom of my spotify_player has been bothering me for too long