[PR #78] Allow unknown domains to fix Podcast functionality #208

New issue

Open

opened 2026-03-01 17:43:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-01 17:43:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/AnanthVivekanand/spotify-adblock/pull/78
Author: @imtherainman
Created: 2/9/2023
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (1)

f960fba Allow unknown domains (#1)

📊 Changes

2 files changed (+9 additions, -3 deletions)

View changed files

📝 mitm-utils/blacklist-mitm.js (+6 -1)
📝 mitm.js (+3 -2)

📄 Description

I've noticed the current implementation breaks functionality for podcast audio. Looking into the logs, it appears to be due to some podcasts retrieving audio data directly from the publisher's domains.

For example, NPR podcasts send requests to edgeX.pod.npr.org, and New York Times uses nyt.simplecastaudio.com:

Since these domains do not appear in either the whitelist or blacklist, they are blocked by mitm.js.

Seeing as there's no way to possibly whitelist every one of these publisher domains, the only workaround I can think of is to allow unknown domains by default, and update blacklist-mitm.js accordingly whenever an advertisement request slips through. I've added the following domains to the blacklist based on what was previously blocked as an unknown domain that would otherwise now be allowed:

spclient.wg.spotify.com/gabo-receiver-service/** (Spotify user data tracking)
spclient.wg.spotify.com/sponsoredplaylist/** (blocks the "sponsered by" visual ads in playlists)
**/*sentry.io*/** (user data tracking)
**/*googleapis*/** (user data tracking)
**/*doubleclick*/** (ads)

I've been using this updated version for a few weeks now without issues, but welcome any feedback or alternative approach. Thanks so much for maintaining this project!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/AnanthVivekanand/spotify-adblock/pull/78 **Author:** [@imtherainman](https://github.com/imtherainman) **Created:** 2/9/2023 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`f960fba`](https://github.com/AnanthVivekanand/spotify-adblock/commit/f960fba7d66d6756eab824c9a5437675a71161bb) Allow unknown domains (#1) ### 📊 Changes **2 files changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `mitm-utils/blacklist-mitm.js` (+6 -1) 📝 `mitm.js` (+3 -2) </details> ### 📄 Description I've noticed the current implementation breaks functionality for podcast audio. Looking into the logs, it appears to be due to some podcasts retrieving audio data directly from the publisher's domains. For example, NPR podcasts send requests to `edgeX.pod.npr.org`, and New York Times uses `nyt.simplecastaudio.com`: ![image](https://user-images.githubusercontent.com/15202629/217938223-4a3808aa-5ae9-42b6-8ab3-a2617e0b1db4.png) Since these domains do not appear in either the whitelist or blacklist, they are [blocked by `mitm.js`](https://github.com/AnanthVivekanand/spotify-adblock/blob/d2b6397369adc7607084a29abfca5dcde067adc4/mitm.js#L63-L68). Seeing as there's no way to possibly whitelist every one of these publisher domains, the only workaround I can think of is to allow unknown domains by default, and update `blacklist-mitm.js` accordingly whenever an advertisement request slips through. I've added the following domains to the blacklist based on what was previously blocked as an unknown domain that would otherwise now be allowed: - `spclient.wg.spotify.com/gabo-receiver-service/**` (Spotify user data tracking) - `spclient.wg.spotify.com/sponsoredplaylist/**` (blocks the "sponsered by" visual ads in playlists) - `**/*sentry.io*/**` (user data tracking) - `**/*googleapis*/**` (user data tracking) - `**/*doubleclick*/**` (ads) I've been using this updated version for a few weeks now without issues, but welcome any feedback or alternative approach. Thanks so much for maintaining this project! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>