mirror of
https://github.com/AnanthVivekanand/spotify-adblock.git
synced 2026-04-29 06:15:50 +03:00
[GH-ISSUE #12] Spotify mutes after some minutes. #11
Labels
No labels
cannot reproduce
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/spotify-adblock#11
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mgoyanes on GitHub (Jul 11, 2020).
Original GitHub issue: https://github.com/AnanthVivekanand/spotify-adblock/issues/12
After some minutes, Spotify stops playing music. Whenever I press the play button, nothing happens.
Have to kill pm, kill Spotify, restart npm and Spotify.
Terminal does not output more than that.
MacOS version: 10.15.5
@AnanthVivekanand commented on GitHub (Jul 11, 2020):
Weird.. I don't know why it would do that.. Can you give me a terminal output of every domain that's pinged? A pastebin link should suffice
I can't reproduce the issue on my side, but try whitelisting
login5.spotify.cominwhitelist.jsand can you tell if anything changes? The reasonlogin5is blocked right now is because it triggers ads fromspclient.wg.spotify.com.@mgoyanes commented on GitHub (Jul 11, 2020):
Hello.
Yep.
login5.spotify.comis the culprit. If I whitelist it ads are played. If I block it, at some point, I am unable to keep listening. Even If I close and restart Spotify, I still can't play anything.Here is the terminal output. That space over there is when it stopped playing, that is, when it skipped to the next track, it then stopped playing.
I'm using Spotify version 1.1.36.734.g8731c306
Thanks.
@AnanthVivekanand commented on GitHub (Jul 11, 2020):
Hm, I don't know why this is happening. I wonder if Spotify is somehow detecting that we're blocking its ads. It might be your Spotify version - when I get back to my computer I'll check my version and upgrade/downgrade to see if I can replicate the issue
The issue with just domain filtering is that
spclient.wg.spotify.comserves music, ads, and Spotify friends functionality. We can't just block it so instead I tried to block everything that triggers it from sending ads. But doing that breaks more functionality, and so on.A workaround that I did was use SSL decryption on
spclient.wg.spotify.comwhere I could actually read the full url of the requests sent there. All the ads from spclient are served from /ads so it was easy to just filter that path. Anyways, the code for the SSL decryption is on the mitm-proxy branch. If you could test that out, that'd be great. If you're up for testing it, you'll need to trust the root CA it creates, an easy command for that is in the readme on that branch.Sorry you're having trouble, it's just the way Spotify ads work :( I'll keep looking into it though
@mgoyanes commented on GitHub (Jul 12, 2020):
I think that that branch solves the issue. Have you tried?
@AnanthVivekanand commented on GitHub (Jul 12, 2020):
So wasn't able to upgrade my Spotify to 1.1.36 exactly, I upgraded to 1.1.37 from 1.1.28. For me, Spotify doesn't stop playing completely, it just can't play certain songs. Selecting a new song works and Spotify will play again. This was already happening on 1.1.28, so I can't seem to replicate your issue.
The reason I'm keeping the
mitm-proxybranch separate from master is because the MITM proxy requires users to add the root CA to their machine and not all users might feel comfortable with that. So users can use the mitm proxy branch over master if desire.And yes, I personally use the
mitm-proxybranch everyday and it works perfectly.@mgoyanes commented on GitHub (Sep 5, 2020):
Hello.
Updated the
mitm-proxybranch to the latest commit and I'm getting this error:In commit
ce0a6eba8f5c671c50ba21472c37c7cfbc73ea94that message does not appear.@AnanthVivekanand commented on GitHub (Sep 5, 2020):
If you look at the commit changes, you'll see that
mitm2.jswas renamed tomitm.js, so runnode mitm.js.@mgoyanes commented on GitHub (Sep 6, 2020):
Sorry. Missed that. Thanks