[PR #10] [MERGED] Fix broken JSON for error messages #34

New issue

Closed

opened 2026-02-28 14:28:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:28:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/entriphy/sp-playcount-librespot/pull/10
Author: @ghost
Created: 8/3/2020
Status: ✅ Merged
Merged: 8/5/2020
Merged by: @entriphy

Base: dev ← Head: fix-error-json

📝 Commits (1)

e47a3d8 Fix broken JSON for error messages

📊 Changes

4 files changed (+25 additions, -16 deletions)

View changed files

📝 core/src/main/java/xyz/gianlu/librespot/handler/ArtistAboutHandler.java (+4 -4)
📝 core/src/main/java/xyz/gianlu/librespot/handler/ArtistInfoHandler.java (+7 -4)
📝 core/src/main/java/xyz/gianlu/librespot/handler/ArtistInsightsHandler.java (+7 -4)
📝 core/src/main/java/xyz/gianlu/librespot/handler/PlayCountHandler.java (+7 -4)

📄 Description

This fixes an issue where the error messages are not quoted, resulting in invalid JSON like this:

❯ curl -s 'https://api.t4ils.dev/albumPlayCount?albumid=4AICAv06yCiu66i4TOPWg'
{"success": false, "data": albumid is invalid; albumid length does not equal 22}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/entriphy/sp-playcount-librespot/pull/10 **Author:** [@ghost](https://github.com/ghost) **Created:** 8/3/2020 **Status:** ✅ Merged **Merged:** 8/5/2020 **Merged by:** [@entriphy](https://github.com/entriphy) **Base:** `dev` ← **Head:** `fix-error-json` --- ### 📝 Commits (1) - [`e47a3d8`](https://github.com/entriphy/sp-playcount-librespot/commit/e47a3d86e09d04e3c1f0f3f164fccd67ad44245e) Fix broken JSON for error messages ### 📊 Changes **4 files changed** (+25 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `core/src/main/java/xyz/gianlu/librespot/handler/ArtistAboutHandler.java` (+4 -4) 📝 `core/src/main/java/xyz/gianlu/librespot/handler/ArtistInfoHandler.java` (+7 -4) 📝 `core/src/main/java/xyz/gianlu/librespot/handler/ArtistInsightsHandler.java` (+7 -4) 📝 `core/src/main/java/xyz/gianlu/librespot/handler/PlayCountHandler.java` (+7 -4) </details> ### 📄 Description This fixes an issue where the error messages are not quoted, resulting in invalid JSON like this: ``` ❯ curl -s 'https://api.t4ils.dev/albumPlayCount?albumid=4AICAv06yCiu66i4TOPWg' {"success": false, "data": albumid is invalid; albumid length does not equal 22} ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>