[PR #85] [MERGED] Fix: Provide ability to configure the XML key for object lookup when updating #83

Closed
opened 2026-02-27 23:18:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/85
Author: @mamullen13316
Created: 10/15/2024
Status: Merged
Merged: 10/15/2024
Merged by: @mamullen13316

Base: mainHead: update_fix


📝 Commits (2)

  • 1659f63 fix: provide ability to configure the lookup key for objects when updating
  • 4ac025b version: update to v0.1.56

📊 Changes

3 files changed (+7 additions, -3 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/api_client.py (+3 -1)
📝 sophosfirewall_python/firewallapi.py (+3 -1)

📄 Description

  • provides ability to configure the lookup_key when doing an update for situations where the object doesn't have a Name key. For example, for snmpv3user, the key is UserName.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/85 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `update_fix` --- ### 📝 Commits (2) - [`1659f63`](https://github.com/sophos/sophos-firewall-sdk/commit/1659f630802746c27376a4a6e37c122cae350eb8) fix: provide ability to configure the lookup key for objects when updating - [`4ac025b`](https://github.com/sophos/sophos-firewall-sdk/commit/4ac025b546dbf4a78006b041815cd847fb52b0ef) version: update to v0.1.56 ### 📊 Changes **3 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/api_client.py` (+3 -1) 📝 `sophosfirewall_python/firewallapi.py` (+3 -1) </details> ### 📄 Description - provides ability to configure the `lookup_key` when doing an update for situations where the object doesn't have a `Name` key. For example, for snmpv3user, the key is `UserName`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:18:59 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sophos-firewall-sdk#83
No description provided.