[PR #78] [MERGED] feat: Updated firewall rule functionality #77

Closed
opened 2026-02-27 23:18:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/78
Author: @mamullen13316
Created: 8/26/2024
Status: Merged
Merged: 8/26/2024
Merged by: @mamullen13316

Base: mainHead: fw_rule_update


📝 Commits (1)

📊 Changes

6 files changed (+224 additions, -7 deletions)

View changed files

📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/firewallapi.py (+28 -1)
📝 sophosfirewall_python/firewallrule.py (+106 -3)
📝 sophosfirewall_python/templates/createfwrule.j2 (+15 -2)
sophosfirewall_python/templates/updatefwrule.j2 (+61 -0)
📝 sophosfirewall_python/tests/functional.py (+13 -0)

📄 Description

  • Added ability to update firewall rules
  • Added argument for position (top, bottom, before, after) when creating rules
  • Added argument for status (enabled/disabled) when creating/updating rules

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/78 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `fw_rule_update` --- ### 📝 Commits (1) - [`4ae3ee9`](https://github.com/sophos/sophos-firewall-sdk/commit/4ae3ee92d1a3681455ea7e7cfc1e59c99072b919) feat: ### 📊 Changes **6 files changed** (+224 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/firewallapi.py` (+28 -1) 📝 `sophosfirewall_python/firewallrule.py` (+106 -3) 📝 `sophosfirewall_python/templates/createfwrule.j2` (+15 -2) ➕ `sophosfirewall_python/templates/updatefwrule.j2` (+61 -0) 📝 `sophosfirewall_python/tests/functional.py` (+13 -0) </details> ### 📄 Description - Added ability to update firewall rules - Added argument for position (top, bottom, before, after) when creating rules - Added argument for status (enabled/disabled) when creating/updating rules - --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 23:18:57 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/sophos-firewall-sdk#77
No description provided.