[PR #16] [MERGED] Fixes and feature updates #18

New issue

Closed

opened 2026-02-27 23:18:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 23:18:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/sophos/sophos-firewall-sdk/pull/16
Author: @mamullen13316
Created: 10/3/2023
Status: ✅ Merged
Merged: 10/3/2023
Merged by: @mamullen13316

Base: main ← Head: fix_case

📝 Commits (5)

eaf4b47 fix: make xml tag case insensitive
2553a29 fix: move verify flag to class level
14b5bb0 feat: add login method for testing credentials
68f27c4 version: update to v0.1.12
7357016 test: add test for login() method

📊 Changes

5 files changed (+168 additions, -158 deletions)

View changed files

📝 docs/examples.rst (+1 -4)
📝 docs/usage.rst (+7 -1)
📝 pyproject.toml (+1 -1)
📝 sophosfirewall_python/firewallapi.py (+122 -151)
📝 sophosfirewall_python/unittests.py (+37 -1)

📄 Description

Make XML tag searches case insensitive
Add login() method to test credentials
Move verify flag for certificate checking to the class

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/sophos/sophos-firewall-sdk/pull/16 **Author:** [@mamullen13316](https://github.com/mamullen13316) **Created:** 10/3/2023 **Status:** ✅ Merged **Merged:** 10/3/2023 **Merged by:** [@mamullen13316](https://github.com/mamullen13316) **Base:** `main` ← **Head:** `fix_case` --- ### 📝 Commits (5) - [`eaf4b47`](https://github.com/sophos/sophos-firewall-sdk/commit/eaf4b477ab529d8b44baca0fb259d337e9646094) fix: make xml tag case insensitive - [`2553a29`](https://github.com/sophos/sophos-firewall-sdk/commit/2553a296ea00ee86f35d6187642f9835dd474c78) fix: move verify flag to class level - [`14b5bb0`](https://github.com/sophos/sophos-firewall-sdk/commit/14b5bb0257c425d2613eae29ddc9698aacdc00c8) feat: add login method for testing credentials - [`68f27c4`](https://github.com/sophos/sophos-firewall-sdk/commit/68f27c4669e2bd185b2bc930763d6c11b4529a23) version: update to v0.1.12 - [`7357016`](https://github.com/sophos/sophos-firewall-sdk/commit/735701675ed5fbda34d100e1799283c64246e396) test: add test for login() method ### 📊 Changes **5 files changed** (+168 additions, -158 deletions) <details> <summary>View changed files</summary> 📝 `docs/examples.rst` (+1 -4) 📝 `docs/usage.rst` (+7 -1) 📝 `pyproject.toml` (+1 -1) 📝 `sophosfirewall_python/firewallapi.py` (+122 -151) 📝 `sophosfirewall_python/unittests.py` (+37 -1) </details> ### 📄 Description - Make XML tag searches case insensitive - Add login() method to test credentials - Move verify flag for certificate checking to the class --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 23:18:44 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/sophos-firewall-sdk#18

No description provided.

Rows
Columns