[PR #860] add ability spadl and atomic spadl format in no_store == True mode. #875

New issue

Open

opened 2026-03-02 15:59:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/860
Author: @shufinskiy
Created: 7/14/2025
Status: 🔄 Open

Base: master ← Head: spadl_no_store

📝 Commits (2)

70938fd add ability spadl and atomic spadl format in no_store == True mode.
021e6f8 fix ruff error

📊 Changes

1 file changed (+6 additions, -6 deletions)

View changed files

📝 soccerdata/whoscored.py (+6 -6)

📄 Description

Hello, @probberechts.

This PR allows you to work with spadl and atomic spadl formats in the mode without saving to disk (no_store == True).

There is a blocker for this PR: my PR to socceraction library to change the behavior of the WhoScoredParser class. It must be accepted for this PR to make sense.

PR in socceraction library:
https://github.com/ML-KULeuven/socceraction/pull/948

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/860 **Author:** [@shufinskiy](https://github.com/shufinskiy) **Created:** 7/14/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `spadl_no_store` --- ### 📝 Commits (2) - [`70938fd`](https://github.com/probberechts/soccerdata/commit/70938fd2e41379f511534ee1490dd20bbfa4eec8) add ability spadl and atomic spadl format in no_store == True mode. - [`021e6f8`](https://github.com/probberechts/soccerdata/commit/021e6f8bf62ed09e79591d780b82bda1ff56ac3e) fix ruff error ### 📊 Changes **1 file changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/whoscored.py` (+6 -6) </details> ### 📄 Description Hello, @probberechts. This PR allows you to work with spadl and atomic spadl formats in the mode without saving to disk (no_store == True). There is a blocker for this PR: my PR to socceraction library to change the behavior of the WhoScoredParser class. It must be accepted for this PR to make sense. PR in socceraction library: https://github.com/ML-KULeuven/socceraction/pull/948 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>