mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[PR #823] [CLOSED] [FotMob] Added support for retrieving "Expected goals on target (xGOT)" stats #845
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#845
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/823
Author: @zack-fathi
Created: 4/1/2025
Status: ❌ Closed
Base:
master← Head:FOTMOB_add_xGOT📝 Commits (2)
139cacaAdd support for 'Expected goals on target (xGOT)' to read_team_match_statse221f9bstyle: auto format pre-commit📊 Changes
2 files changed (+25 additions, -2 deletions)
View changed files
📝
soccerdata/fotmob.py(+15 -1)📝
tests/test_FotMob.py(+10 -1)📄 Description
Changes Made
read_team_match_statsto recognize and extract the"xG on target (xGOT)"field from within the"Expected goals (xG)"section.test_read_team_match_stats) to includestat_type="Expected goals on target (xGOT)".Closes #781 — This feature allows users to explicitly request xGOT data, which was previously included in the data but not directly accessible.
Note: CI failures are unrelated to this PR. The failing tests are in
FiveThirtyEightandSoFIFA, which were not touched in this PR. Errors appear to be caused by external data sources returning unexpected or malformed data (e.g., HTML instead of JSON).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.