[PR #822] [MERGED] [SoFIFA] Fix iteration indent error in read_player_ratings #844

New issue

Closed

opened 2026-03-02 15:59:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/822
Author: @Trouvaille0198
Created: 4/1/2025
Status: ✅ Merged
Merged: 5/22/2025
Merged by: @probberechts

Base: master ← Head: master

📝 Commits (1)

1fd8403 fix(SoFIFA): fix iteration indent error in read_player_ratings

📊 Changes

1 file changed (+16 additions, -16 deletions)

View changed files

📝 soccerdata/sofifa.py (+16 -16)

📄 Description

Fix iteration indent error in SoFIFA.read_player_ratings

Test code:
Before fixing: method read_player_ratings would return only one line information
After fixing:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/822 **Author:** [@Trouvaille0198](https://github.com/Trouvaille0198) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 5/22/2025 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`1fd8403`](https://github.com/probberechts/soccerdata/commit/1fd8403d4c5b81859904fafbd38f3509158c8bee) fix(SoFIFA): fix iteration indent error in read_player_ratings ### 📊 Changes **1 file changed** (+16 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/sofifa.py` (+16 -16) </details> ### 📄 Description Fix iteration indent error in `SoFIFA.read_player_ratings` - Test code: ![image](https://github.com/user-attachments/assets/7660d007-3bae-472e-a7ea-47d346d8c007) - Before fixing: method `read_player_ratings` would return only one line information ![image](https://github.com/user-attachments/assets/0285a901-b383-4465-a8e8-6cb6312880de) - After fixing: ![image](https://github.com/user-attachments/assets/77e40969-9800-47db-bdcb-f4f5e114fe42) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>