[GH-ISSUE #479] [Nox] Documentation sessions create a ~ directory #84

New issue

Closed

opened 2026-03-02 15:55:38 +03:00 by kerem · 1 comment

kerem commented

2026-03-02 15:55:38 +03:00

Owner

Originally created by @JanVanHaaren on GitHub (Feb 11, 2024).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/479

The docs and docs-build Nox sessions create a ~ directory on my machine, which I believe is unintentional.

github.com/probberechts/soccerdata@a565388b1c/noxfile.py (L190)

github.com/probberechts/soccerdata@a565388b1c/noxfile.py (L204)

The tilde (~) is not expanded to my home directory, where my soccerdata directory is located.

Potential solutions include using Path.home() as is done elsewhere, using os.path.expanduser, and using BASE_DIR from _config.py. Depending on which solution is most desirable, I can create a pull request to address this issue.

Originally created by @JanVanHaaren on GitHub (Feb 11, 2024). Original GitHub issue: https://github.com/probberechts/soccerdata/issues/479 The `docs` and `docs-build` Nox sessions create a `~` directory on my machine, which I believe is unintentional. https://github.com/probberechts/soccerdata/blob/a565388b1cb359e25ad1a902059fb947ea559831/noxfile.py#L190 https://github.com/probberechts/soccerdata/blob/a565388b1cb359e25ad1a902059fb947ea559831/noxfile.py#L204 The tilde (`~`) is not expanded to my `home` directory, where my `soccerdata` directory is located. Potential solutions include using `Path.home()` as is done elsewhere, using `os.path.expanduser`, and using `BASE_DIR` from `_config.py`. Depending on which solution is most desirable, I can create a pull request to address this issue.

kerem

2026-03-02 15:55:38 +03:00

closed this issue
added the
build
label

kerem commented

2026-03-02 15:55:39 +03:00

Author

Owner

@probberechts commented on GitHub (Feb 11, 2024):

I remember that there was a good reason to use the default '~/soccerdata' instead of the value in _config.py which might be overridden by an environment variable. However, I forgot the reason 🤔

Replacing '~' with Path.home() would be a good solution. Feel free to create a PR. Otherwise I can easily fix this myself.

@probberechts commented on GitHub (Feb 11, 2024): I remember that there was a good reason to use the default '~/soccerdata' instead of the value in `_config.py` which might be overridden by an environment variable. However, I forgot the reason 🤔 Replacing '~' with `Path.home()` would be a good solution. Feel free to create a PR. Otherwise I can easily fix this myself.

kerem referenced this issue

2026-03-02 15:57:08 +03:00

[PR #84] [MERGED] Update dependency mypy to ^0.981 #267