[PR #806] Feature to extract players ID in FBREF #834

Open
opened 2026-03-02 15:59:48 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/806
Author: @michaelromagne
Created: 2/3/2025
Status: 🔄 Open

Base: masterHead: master


📝 Commits (7)

  • e9811b9 Add feature to extract players URL in fbref
  • 43615c7 Merge branch 'probberechts:master' into master
  • f6355ed Merge branch 'probberechts:master' into master
  • 5ee4e54 Extract player ID from fbref
  • b0ae15a Merge branch 'probberechts:master' into master
  • df3c4ca Merge branch 'probberechts:master' into master
  • e2e519f chore: error handling in fbref

📊 Changes

3 files changed (+192 additions, -69 deletions)

View changed files

📝 soccerdata/_common.py (+41 -18)
📝 soccerdata/fbref.py (+134 -47)
📝 tests/test_FBref.py (+17 -4)

📄 Description

This PR adds an option in the read_player_season_stats method. When extracting player statistics, it may be interesting to get the URL to the player page as well. This way, we can get additional information in our application with a simple scraping on the player page (for instance, the player picture).


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/806 **Author:** [@michaelromagne](https://github.com/michaelromagne) **Created:** 2/3/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`e9811b9`](https://github.com/probberechts/soccerdata/commit/e9811b930914d402d834c5f9d4bbb795b0b8e0fd) Add feature to extract players URL in fbref - [`43615c7`](https://github.com/probberechts/soccerdata/commit/43615c7e940b354289dc6e474c3ab26e8d2a83c4) Merge branch 'probberechts:master' into master - [`f6355ed`](https://github.com/probberechts/soccerdata/commit/f6355ed8b8c24ff728df34a2ae106cfad28a17bc) Merge branch 'probberechts:master' into master - [`5ee4e54`](https://github.com/probberechts/soccerdata/commit/5ee4e54be6230d8b0fe5da5748391f478fe56ecc) Extract player ID from fbref - [`b0ae15a`](https://github.com/probberechts/soccerdata/commit/b0ae15ad258ed3d33f7275eecbcbaa6aa51e6327) Merge branch 'probberechts:master' into master - [`df3c4ca`](https://github.com/probberechts/soccerdata/commit/df3c4cac9cabc017ab9108d4b7424e6286312732) Merge branch 'probberechts:master' into master - [`e2e519f`](https://github.com/probberechts/soccerdata/commit/e2e519fac9792e2c367c004f63e887864e14321f) chore: error handling in fbref ### 📊 Changes **3 files changed** (+192 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/_common.py` (+41 -18) 📝 `soccerdata/fbref.py` (+134 -47) 📝 `tests/test_FBref.py` (+17 -4) </details> ### 📄 Description This PR adds an option in the `read_player_season_stats` method. When extracting player statistics, it may be interesting to get the URL to the player page as well. This way, we can get additional information in our application with a simple scraping on the player page (for instance, the player picture). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#834
No description provided.