mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[PR #806] Feature to extract players ID in FBREF #834
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#834
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/806
Author: @michaelromagne
Created: 2/3/2025
Status: 🔄 Open
Base:
master← Head:master📝 Commits (7)
e9811b9Add feature to extract players URL in fbref43615c7Merge branch 'probberechts:master' into masterf6355edMerge branch 'probberechts:master' into master5ee4e54Extract player ID from fbrefb0ae15aMerge branch 'probberechts:master' into masterdf3c4caMerge branch 'probberechts:master' into mastere2e519fchore: error handling in fbref📊 Changes
3 files changed (+192 additions, -69 deletions)
View changed files
📝
soccerdata/_common.py(+41 -18)📝
soccerdata/fbref.py(+134 -47)📝
tests/test_FBref.py(+17 -4)📄 Description
This PR adds an option in the
read_player_season_statsmethod. When extracting player statistics, it may be interesting to get the URL to the player page as well. This way, we can get additional information in our application with a simple scraping on the player page (for instance, the player picture).🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.