[PR #755] [MERGED] [ClubElo, FotMob, SoFIFA, FBREF] Fixing and unifying TEAMNAME_REPLACEMENTS loading #791

New issue

Closed

opened 2026-03-02 15:59:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/755
Author: @MartiONE
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/25/2024
Merged by: @probberechts

Base: master ← Head: master

📝 Commits (10+)

229a64a Plugin export needs to be added now to poetry
b6f40bc Fixing ClubElo TEAMNAME_REPLACEMENTS
4731448 Fixing FotMob TEAMNAME_REPLACEMENTS
4d0ee7d Fixing SoFIFA TEAMNAME_REPLACEMENTS
4a63a88 Fixing FBREF TEAMNAME_REPLACEMENTS & adjusting ClubElo logic to be in line with the other classes
d7bb112 Fixing teamname_replacements config file
6800f43 Adding alt name test to FBref
de32631 Fixing FotMob tests and re-enabling them
96a56c2 linter fixes
3337438 refactor

📊 Changes

11 files changed (+133 additions, -36 deletions)

View changed files

📝 CONTRIBUTING.rst (+1 -0)
📝 soccerdata/_common.py (+56 -1)
📝 soccerdata/clubelo.py (+3 -7)
📝 soccerdata/fbref.py (+8 -9)
📝 soccerdata/fotmob.py (+4 -9)
📝 soccerdata/sofifa.py (+2 -9)
📝 tests/appdata/config/teamname_replacements.json (+4 -1)
📝 tests/test_FBref.py (+13 -0)
📝 tests/test_FotMob.py (+13 -0)
📝 tests/test_SoFIFA.py (+10 -0)
📝 tests/test_common.py (+19 -0)

📄 Description

This fixes #703

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/755 **Author:** [@MartiONE](https://github.com/MartiONE) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 11/25/2024 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`229a64a`](https://github.com/probberechts/soccerdata/commit/229a64ae77bee4c822ccf4fc8793d08703dafb95) Plugin export needs to be added now to poetry - [`b6f40bc`](https://github.com/probberechts/soccerdata/commit/b6f40bc4e4bbce61c63c47b12d937b119caa7237) Fixing ClubElo TEAMNAME_REPLACEMENTS - [`4731448`](https://github.com/probberechts/soccerdata/commit/47314489dc7356b56b3f2c3726f010a069649b8d) Fixing FotMob TEAMNAME_REPLACEMENTS - [`4d0ee7d`](https://github.com/probberechts/soccerdata/commit/4d0ee7dd345a8cad2ce2683c273b4900f82fea2a) Fixing SoFIFA TEAMNAME_REPLACEMENTS - [`4a63a88`](https://github.com/probberechts/soccerdata/commit/4a63a8893370bac354c1794072f07a5b5013d61b) Fixing FBREF TEAMNAME_REPLACEMENTS & adjusting ClubElo logic to be in line with the other classes - [`d7bb112`](https://github.com/probberechts/soccerdata/commit/d7bb1123bfa88bb7c54172102506c0801dfa0ca5) Fixing teamname_replacements config file - [`6800f43`](https://github.com/probberechts/soccerdata/commit/6800f43e208b0cac98c2ff73937c2c26e009708c) Adding alt name test to FBref - [`de32631`](https://github.com/probberechts/soccerdata/commit/de326318a339ea66efbb6bbb84b6a51458e695f5) Fixing FotMob tests and re-enabling them - [`96a56c2`](https://github.com/probberechts/soccerdata/commit/96a56c2a33bbf83888252bfe125cb25a559173fd) linter fixes - [`3337438`](https://github.com/probberechts/soccerdata/commit/3337438c82868a777d5b8f9780d91ef897668d53) refactor ### 📊 Changes **11 files changed** (+133 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `CONTRIBUTING.rst` (+1 -0) 📝 `soccerdata/_common.py` (+56 -1) 📝 `soccerdata/clubelo.py` (+3 -7) 📝 `soccerdata/fbref.py` (+8 -9) 📝 `soccerdata/fotmob.py` (+4 -9) 📝 `soccerdata/sofifa.py` (+2 -9) 📝 `tests/appdata/config/teamname_replacements.json` (+4 -1) 📝 `tests/test_FBref.py` (+13 -0) 📝 `tests/test_FotMob.py` (+13 -0) 📝 `tests/test_SoFIFA.py` (+10 -0) 📝 `tests/test_common.py` (+19 -0) </details> ### 📄 Description This fixes #703 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>