mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[PR #640] [MERGED] [Fotmob] Include matches which ended in extra time or after penalties #712
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#712
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/640
Author: @J-Owens
Created: 7/15/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @probberechts
Base:
master← Head:master📝 Commits (1)
e711181Include matches which ended in extra time or after penalties for fotmob read_match_stats📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
soccerdata/fotmob.py(+1 -1)📄 Description
Currently only games which were concluded in standard time are returned from read_match_stats as the status code for games that were decided in extra time or by penalties do not have the "FT" status.
I am re-raising this PR as the previous PR failed on the codecov check as it wasn't enabled on my repository when I made the PR, and I could not see how to trigger another check, and would rather just re-raise the PR than push a dummy commit.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.