[PR #640] [MERGED] [Fotmob] Include matches which ended in extra time or after penalties #712

Closed
opened 2026-03-02 15:59:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/640
Author: @J-Owens
Created: 7/15/2024
Status: Merged
Merged: 7/18/2024
Merged by: @probberechts

Base: masterHead: master


📝 Commits (1)

  • e711181 Include matches which ended in extra time or after penalties for fotmob read_match_stats

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 soccerdata/fotmob.py (+1 -1)

📄 Description

Currently only games which were concluded in standard time are returned from read_match_stats as the status code for games that were decided in extra time or by penalties do not have the "FT" status.

I am re-raising this PR as the previous PR failed on the codecov check as it wasn't enabled on my repository when I made the PR, and I could not see how to trigger another check, and would rather just re-raise the PR than push a dummy commit.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/640 **Author:** [@J-Owens](https://github.com/J-Owens) **Created:** 7/15/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`e711181`](https://github.com/probberechts/soccerdata/commit/e711181cd825bd62627e4639c0d6d2ad99de82fd) Include matches which ended in extra time or after penalties for fotmob read_match_stats ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fotmob.py` (+1 -1) </details> ### 📄 Description Currently only games which were concluded in standard time are returned from read_match_stats as the status code for games that were decided in extra time or by penalties do not have the "FT" status. I am re-raising this PR as the previous PR failed on the codecov check as it wasn't enabled on my repository when I made the PR, and I could not see how to trigger another check, and would rather just re-raise the PR than push a dummy commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 15:59:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#712
No description provided.