[PR #636] [MERGED] [WhoScored] Error handling for missing events #710

New issue

Closed

opened 2026-03-02 15:59:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/636
Author: @probberechts
Created: 7/8/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @probberechts

Base: master ← Head: fix/iss633

📝 Commits (3)

450ccff fix(whoscored): error handling for missing events
f8a174a chore(linting): ruff
d88880d fix(WhoScored): read only once

📊 Changes

2 files changed (+13 additions, -6 deletions)

View changed files

📝 soccerdata/_common.py (+7 -4)
📝 soccerdata/whoscored.py (+6 -2)

📄 Description

Previously, the javascript variable that stores all events was empty when no events were available for a given game. Since the change fixed in #618, the javascript variable is missing instead, resulting in a JavascriptException. This commit updates the error handling accordingly.

Closes #633

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/636 **Author:** [@probberechts](https://github.com/probberechts) **Created:** 7/8/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `fix/iss633` --- ### 📝 Commits (3) - [`450ccff`](https://github.com/probberechts/soccerdata/commit/450ccff2fb6832dac95846c42bea0a8d472e90b5) fix(whoscored): error handling for missing events - [`f8a174a`](https://github.com/probberechts/soccerdata/commit/f8a174a87c0ce31548b90186f20e5f5ebac69395) chore(linting): ruff - [`d88880d`](https://github.com/probberechts/soccerdata/commit/d88880da57e27e74f45dbb51477bf12b3dafe767) fix(WhoScored): read only once ### 📊 Changes **2 files changed** (+13 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/_common.py` (+7 -4) 📝 `soccerdata/whoscored.py` (+6 -2) </details> ### 📄 Description Previously, the javascript variable that stores all events was empty when no events were available for a given game. Since the change fixed in #618, the javascript variable is missing instead, resulting in a `JavascriptException`. This commit updates the error handling accordingly. Closes #633 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>