[PR #595] [MERGED] [FBref] Avoid duplicate Big 5 leagues #687

New issue

Closed

opened 2026-03-02 15:59:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/595
Author: @probberechts
Created: 5/27/2024
Status: ✅ Merged
Merged: 5/27/2024
Merged by: @probberechts

Base: master ← Head: fix/fbref-big5-duplicated

📝 Commits (1)

4318ee4 fix(fbref): Avoid duplicate Big 5 leagues

📊 Changes

1 file changed (+56 additions, -19 deletions)

View changed files

📝 soccerdata/fbref.py (+56 -19)

📄 Description

When the FBref reader was initialized with leagues=["Big 5 European Leagues Combined", ...] where ... contains other leagues from the Big 5 (e.g., "ENG-Premier League") it would scrape the league twice.

Fixes #576

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/595 **Author:** [@probberechts](https://github.com/probberechts) **Created:** 5/27/2024 **Status:** ✅ Merged **Merged:** 5/27/2024 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `fix/fbref-big5-duplicated` --- ### 📝 Commits (1) - [`4318ee4`](https://github.com/probberechts/soccerdata/commit/4318ee4dd8b70c5b8d6ddaf7ae702ca8a79d898a) fix(fbref): Avoid duplicate Big 5 leagues ### 📊 Changes **1 file changed** (+56 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+56 -19) </details> ### 📄 Description When the FBref reader was initialized with leagues=["Big 5 European Leagues Combined", ...] where ... contains other leagues from the Big 5 (e.g., "ENG-Premier League") it would scrape the league twice. Fixes #576 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>