raise when scraping match events fails #685

New issue

Closed

opened 2026-03-02 15:59:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:59:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/592
Author: @probberechts
Created: 5/24/2024
Status: ✅ Merged
Merged: 5/27/2024
Merged by: @probberechts

Base: master ← Head: feat/whoscored-skip-on-fail

📝 Commits (4)

384351e feat(whoscored): option to skip match on error
5ee04c3 chore: fix typo
9ba6c80 Change on_error parameter
c479f3e chore: linting

📊 Changes

2 files changed (+42 additions, -14 deletions)

View changed files

📝 soccerdata/_common.py (+5 -1)
📝 soccerdata/whoscored.py (+37 -13)

📄 Description

Adds a "retry_missing" option to the read_events method to control whether to retry or skip games for which no events are available.
Adds a "skip_on_error" option to the read_events method to control whether to raise an exception or skip the match when the match page cannot be retrieved.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/592 **Author:** [@probberechts](https://github.com/probberechts) **Created:** 5/24/2024 **Status:** ✅ Merged **Merged:** 5/27/2024 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `feat/whoscored-skip-on-fail` --- ### 📝 Commits (4) - [`384351e`](https://github.com/probberechts/soccerdata/commit/384351e8893f29238477ea48195a640407a976ba) feat(whoscored): option to skip match on error - [`5ee04c3`](https://github.com/probberechts/soccerdata/commit/5ee04c393eaca62db2f8783cc6b81ef34fdf8646) chore: fix typo - [`9ba6c80`](https://github.com/probberechts/soccerdata/commit/9ba6c8013d96a355fffa3317df4bf243186071b7) Change on_error parameter - [`c479f3e`](https://github.com/probberechts/soccerdata/commit/c479f3eb47c4d79f31a9eb6c732fc8b2f1c60c6e) chore: linting ### 📊 Changes **2 files changed** (+42 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/_common.py` (+5 -1) 📝 `soccerdata/whoscored.py` (+37 -13) </details> ### 📄 Description - Adds a "retry_missing" option to the read_events method to control whether to retry or skip games for which no events are available. - Adds a "skip_on_error" option to the read_events method to control whether to raise an exception or skip the match when the match page cannot be retrieved. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>