mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-26 02:25:51 +03:00
[GH-ISSUE #305] [FBref] Handle identically named players in read_lineups #60
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#60
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mhd0528 on GitHub (Jul 25, 2023).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/305
Hi,
I notice there can be duplicates when checking lineups for games in FBref when there are teammates with the same name.
e.g. game_id = f3686357, there are two Paulinho in the team. And when I try to get the lineup, there are 4 Paulinho (2 for each) in the lineup data frame.
It's easy to fix by adding a drop_duplicates() after getting the DF. Just want to bring it up so that maybe it can be fixed inside the package.