mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 18:15:58 +03:00
[PR #461] [MERGED] Add support for scraping FotMob #580
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#580
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/461
Author: @marcjbaron
Created: 1/17/2024
Status: ✅ Merged
Merged: 2/7/2024
Merged by: @probberechts
Base:
master← Head:fotmob📝 Commits (10+)
70c8ee0Initial commitcd533c9Merge branch 'fotmob' of https://github.com/marcjbaron/soccerdata into fotmob6d8a6f6Add fotmob tests; add 'read_game_match_stats' method3c2771dMerge branch 'probberechts:master' into fotmob1e01e72Merge branch 'probberechts:master' into fotmob8ece422fix: read_league_table() for leagues without playoffsd3d3b9fMerge branch 'fotmob' of https://github.com/marcjbaron/soccerdata into fotmob90224ecUpdate tests; change formatting; use translate_leagues9d4365eFix formattingb1a0f5fReduce complexity of read_league_table function📊 Changes
14 files changed (+1259 additions, -4 deletions)
View changed files
📝
.github/labels.yml(+3 -0)📝
README.rst(+4 -3)➕
docs/datasources/FotMob.ipynb(+749 -0)📝
docs/datasources/index.rst(+1 -0)📝
docs/howto/custom-leagues.rst(+7 -0)📝
docs/index.rst(+3 -1)➕
docs/reference/fotmob.rst(+8 -0)📝
docs/reference/index.rst(+1 -0)📝
soccerdata/__init__.py(+2 -0)📝
soccerdata/_config.py(+7 -0)📝
soccerdata/fbref.py(+1 -0)➕
soccerdata/fotmob.py(+437 -0)📝
tests/conftest.py(+6 -0)➕
tests/test_FotMob.py(+30 -0)📄 Description
Hello,
This is an attempt at adding Fotmob as a data source to soccerdata. The nox test suite passed without errors, with the exception of the python-3.8 tests (but the current python dependency in the pyproject.toml file is >=3.9, so I don't know if this can be safely ignored). Unit tests were also created and passed successfully.
The current methods are:
There are obviously other methods that could be added (e.g. season stats), but did not want to go much further until early issues are dealt with.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.