mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-26 02:25:51 +03:00
[GH-ISSUE #46] [FBref] Seasons parameter does not work with read_player_season_stats method #5
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#5
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Suwadith on GitHub (May 27, 2022).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/46
FBRef read_player_season_stats method does not seems to be considering the seasons parameter. No matter what the season is mentioned inside the brackets it just retrevied the recent season player stats. 2021-2022.
Code used is mentioned below
Seasons parameter works perfectly with the read_team_season_stats method though.
@Suwadith commented on GitHub (May 31, 2022):
Thanks for the update.
I still don't think this issue has been fixed.
I tried using the new 1.0.1 version, but the issue still prevails.
Below in the screenshot you can see that some of these players should not exists in the 15-16 squad.
It retrieves the data from the 2021-2022 season which is the most recent season ignoring the seasons parameter.
@probberechts commented on GitHub (May 31, 2022):
Did you empty the cache? Try to set
no_cache=Trueor remove the~/soccerdata/data/FBrefdirectory.Also make sure you are really running the updated version by running
print(sd.__version__).@Suwadith commented on GitHub (May 31, 2022):
My bad. Thank you so much for pointing it out.
It works perfectly :)