[PR #306] [MERGED] [FBref] Handle teammates with identical name #448

New issue

Closed

opened 2026-03-02 15:58:00 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:58:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/306
Author: @probberechts
Created: 7/25/2023
Status: ✅ Merged
Merged: 7/25/2023
Merged by: @probberechts

Base: master ← Head: fbref-fix-lineup-duplicates

📝 Commits (2)

c69c7d9 [FBref] Handle teammates with identical name
8bc86c9 Linting

📊 Changes

1 file changed (+9 additions, -3 deletions)

View changed files

📝 soccerdata/fbref.py (+9 -3)

📄 Description

When two players in the same team have identical names, the output of the read_lineups function would return duplicates. This is fixed by using the jersey number as an additional merge key.

Fixes #305

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/306 **Author:** [@probberechts](https://github.com/probberechts) **Created:** 7/25/2023 **Status:** ✅ Merged **Merged:** 7/25/2023 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `fbref-fix-lineup-duplicates` --- ### 📝 Commits (2) - [`c69c7d9`](https://github.com/probberechts/soccerdata/commit/c69c7d9a406b833dc0100c451b0a13c9353ee1e9) [FBref] Handle teammates with identical name - [`8bc86c9`](https://github.com/probberechts/soccerdata/commit/8bc86c95f2261206239145cd3067a7f811fa9e02) Linting ### 📊 Changes **1 file changed** (+9 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+9 -3) </details> ### 📄 Description When two players in the same team have identical names, the output of the read_lineups function would return duplicates. This is fixed by using the jersey number as an additional merge key. Fixes #305 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>