[PR #286] [CLOSED] Changed logic in _concat to fix error thrown on forfeited matches #432

New issue

Closed

opened 2026-03-02 15:57:55 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:57:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/286
Author: @lorenzodb1
Created: 7/7/2023
Status: ❌ Closed

Base: master ← Head: lorenzodb1_fix_tottenham_concat_bug

📝 Commits (3)

769ef89 Changed logic in _concat to fix error thrown on forfeited matches
c6bba5a Removed unused import
c062f13 Removed unused variable

📊 Changes

1 file changed (+5 additions, -12 deletions)

View changed files

📝 soccerdata/fbref.py (+5 -12)

📄 Description

_concat would throw an error when analysing Tottenham-Rennes, as the game was forfeited and, therefore, there is no match data available for it. The dataframe resulting from this page had fewer columns than the ones for other games in the competition, thus throwing an error.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/286 **Author:** [@lorenzodb1](https://github.com/lorenzodb1) **Created:** 7/7/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `lorenzodb1_fix_tottenham_concat_bug` --- ### 📝 Commits (3) - [`769ef89`](https://github.com/probberechts/soccerdata/commit/769ef89c90b5c4599603f17aea4bef85d148dd51) Changed logic in _concat to fix error thrown on forfeited matches - [`c6bba5a`](https://github.com/probberechts/soccerdata/commit/c6bba5aade1aa6e72bafdc325934e81026d41f82) Removed unused import - [`c062f13`](https://github.com/probberechts/soccerdata/commit/c062f13a137b9a3074fc24f7de215436f49eaf42) Removed unused variable ### 📊 Changes **1 file changed** (+5 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+5 -12) </details> ### 📄 Description `_concat` would throw an error when analysing [Tottenham-Rennes](https://fbref.com/en/matches/d69a0a11/Tottenham-Hotspur-Rennes-December-9-2021-Europa-Conference-League), as the game was forfeited and, therefore, there is no match data available for it. The dataframe resulting from this page had fewer columns than the ones for other games in the competition, thus throwing an error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>