[PR #283] [MERGED] [FBref] Fix invalid cache filenames in read_team_season_stats #429

Closed
opened 2026-03-02 15:57:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/283
Author: @lorenzodb1
Created: 7/7/2023
Status: Merged
Merged: 7/8/2023
Merged by: @probberechts

Base: masterHead: lorenzodb1-team-season-stats-fix


📝 Commits (2)

  • 1e4c564 Fixed issue affecting cached team season stats
  • 3d55a3f Fixed issue affecting cached team season stats

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 soccerdata/fbref.py (+1 -3)

📄 Description

The filename for the cached team season stats was appended with "all", regardless of the type of stats queried. This caused an issue as the cache might not have contained the table needed. It now caches these tables in different files.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/283 **Author:** [@lorenzodb1](https://github.com/lorenzodb1) **Created:** 7/7/2023 **Status:** ✅ Merged **Merged:** 7/8/2023 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `lorenzodb1-team-season-stats-fix` --- ### 📝 Commits (2) - [`1e4c564`](https://github.com/probberechts/soccerdata/commit/1e4c5640300644a2c62f285236add5a4ed781db2) Fixed issue affecting cached team season stats - [`3d55a3f`](https://github.com/probberechts/soccerdata/commit/3d55a3fd2a8f5b6545a4472e5b9acf1d7e3cd4a7) Fixed issue affecting cached team season stats ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+1 -3) </details> ### 📄 Description The filename for the cached team season stats was appended with "all", regardless of the type of stats queried. This caused an issue as the cache might not have contained the table needed. It now caches these tables in different files. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 15:57:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#429
No description provided.