mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 18:15:58 +03:00
[PR #283] [MERGED] [FBref] Fix invalid cache filenames in read_team_season_stats #429
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#429
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/probberechts/soccerdata/pull/283
Author: @lorenzodb1
Created: 7/7/2023
Status: ✅ Merged
Merged: 7/8/2023
Merged by: @probberechts
Base:
master← Head:lorenzodb1-team-season-stats-fix📝 Commits (2)
1e4c564Fixed issue affecting cached team season stats3d55a3fFixed issue affecting cached team season stats📊 Changes
1 file changed (+1 additions, -3 deletions)
View changed files
📝
soccerdata/fbref.py(+1 -3)📄 Description
The filename for the cached team season stats was appended with "all", regardless of the type of stats queried. This caused an issue as the cache might not have contained the table needed. It now caches these tables in different files.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.