[PR #282] [CLOSED] Fixed bug that makes FBref tests fail #428

New issue

Closed

opened 2026-03-02 15:57:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:57:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/282
Author: @lorenzodb1
Created: 7/7/2023
Status: ❌ Closed

Base: master ← Head: lorenzodb1-team-season-stats-cache-fix

📝 Commits (2)

87b2a59 Moved pretty-error to dev dependency and fixed bug making FBref tests fail
412172b Moved pretty-error to dev dependency and fixed bug making FBref tests fail

📊 Changes

4 files changed (+338 additions, -413 deletions)

View changed files

📝 poetry.lock (+335 -409)
📝 pyproject.toml (+2 -2)
📝 soccerdata/_config.py (+0 -1)
📝 soccerdata/fbref.py (+1 -1)

📄 Description

The test failed as it tried to get the length of itertools.product, which does not have that property.

Furthermore, this PR:

it upgrades pandas to v2.0
it moves pretty-errors to the dev dependencies group, as it would otherwise be installed in repositories importing this library (which should not be the case). I'm not sure I've done this correctly, and I had to remove some imports, so please let me know if this breaks previous behaviour and advise me on what I should do instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/282 **Author:** [@lorenzodb1](https://github.com/lorenzodb1) **Created:** 7/7/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `lorenzodb1-team-season-stats-cache-fix` --- ### 📝 Commits (2) - [`87b2a59`](https://github.com/probberechts/soccerdata/commit/87b2a59314527e5a8581be7ed2667e23a4bbaa9b) Moved pretty-error to dev dependency and fixed bug making FBref tests fail - [`412172b`](https://github.com/probberechts/soccerdata/commit/412172bef837b8e001681f96ae34e741fe9c2d4c) Moved pretty-error to dev dependency and fixed bug making FBref tests fail ### 📊 Changes **4 files changed** (+338 additions, -413 deletions) <details> <summary>View changed files</summary> 📝 `poetry.lock` (+335 -409) 📝 `pyproject.toml` (+2 -2) 📝 `soccerdata/_config.py` (+0 -1) 📝 `soccerdata/fbref.py` (+1 -1) </details> ### 📄 Description The test failed as it tried to get the length of `itertools.product`, which does not have that property. Furthermore, this PR: - it upgrades `pandas` to v2.0 - it moves `pretty-errors` to the dev dependencies group, as it would otherwise be installed in repositories importing this library (which should not be the case). I'm not sure I've done this correctly, and I had to remove some imports, so please let me know if this breaks previous behaviour and advise me on what I should do instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>