mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[GH-ISSUE #156] [WhoScored] Enable setting ChomeDriver version manually #37
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#37
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jerem1e on GitHub (Feb 3, 2023).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/156
I have just tried using the library on an older machine and Chrome was a bit outdated, which caused the library to raise:
This can easily be fixed, by allowing to add
version_mainto theundetected_chromedriver.ChromeDriver.For me I had to change the line 412 in
_common.pyto:But it would be great to have the user set this when initializing the
WhoScoredobject or any other object that needs a Chrome-driver (but I think this is only relevant for WhoScored?)@pytoni commented on GitHub (Sep 1, 2023):
I got the same issue. My Chrome version is 116.
I did change _common.py to return uc.Chrome(options=chrome_options, version_main=116), but it's not working.