[PR #74] [MERGED] FBRef - replace 'season' data stat with 'year_id' #262

Closed
opened 2026-03-02 15:57:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/probberechts/soccerdata/pull/74
Author: @jonathan-bull
Created: 8/9/2022
Status: Merged
Merged: 8/10/2022
Merged by: @probberechts

Base: masterHead: fbref-seasons


📝 Commits (3)

  • 2eb58b2 FBRef - replace 'season' data stat with 'year_id'
  • 7df2d6d Linting
  • 54ac75a Replace 'squad' data stat with 'team'

📊 Changes

1 file changed (+4 additions, -2 deletions)

View changed files

📝 soccerdata/fbref.py (+4 -2)

📄 Description

FBRef appears to have switched to using year_id as the data-stat attribute on its seasons table.

This change allows the read_seasons function to return the expected seasons.

Screenshot 2022-08-09 at 19 40 12


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/probberechts/soccerdata/pull/74 **Author:** [@jonathan-bull](https://github.com/jonathan-bull) **Created:** 8/9/2022 **Status:** ✅ Merged **Merged:** 8/10/2022 **Merged by:** [@probberechts](https://github.com/probberechts) **Base:** `master` ← **Head:** `fbref-seasons` --- ### 📝 Commits (3) - [`2eb58b2`](https://github.com/probberechts/soccerdata/commit/2eb58b27750d0414e2b9ee500eee711a315e41da) FBRef - replace 'season' data stat with 'year_id' - [`7df2d6d`](https://github.com/probberechts/soccerdata/commit/7df2d6d378fbe4756122df9b701e2bc94b58d588) Linting - [`54ac75a`](https://github.com/probberechts/soccerdata/commit/54ac75a011f35b8cfda287a80ce85f5cb646f36f) Replace 'squad' data stat with 'team' ### 📊 Changes **1 file changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `soccerdata/fbref.py` (+4 -2) </details> ### 📄 Description FBRef appears to have switched to using `year_id` as the `data-stat` attribute on its seasons table. This change allows the `read_seasons` function to return the expected seasons. ![Screenshot 2022-08-09 at 19 40 12](https://user-images.githubusercontent.com/19507676/183736451-729b1de8-319b-4b21-9158-066b6e052444.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 15:57:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#262
No description provided.