mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[GH-ISSUE #728] [FBref] Add unique identifiers to players and teams datasets #157
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#157
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @lorenzodb1 on GitHub (Oct 16, 2024).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/728
FBref provides a unique 8-character ID for each player and team. This can be particularly useful when working with large datasets. I was wondering if we could include this in the data returned by the scraper.
The following is an example of the IDs provided: fbref.com/en/players/c115db1e/Dailon-Livramento
@probberechts commented on GitHub (Oct 30, 2024):
Yes, good idea! Would you be able to implement this?
@MartiONE commented on GitHub (Nov 25, 2024):
I can do this @probberechts if @lorenzodb1 is OK with it :)
@lorenzodb1 commented on GitHub (Dec 7, 2024):
@MartiONE I already have the code somewhere but feel free to do so if you'd like (unless you already did since it took me two weeks to respond to you 😅)
@MartiONE commented on GitHub (Dec 10, 2024):
Hey @lorenzodb1, lets not do the same work twice then, feel free to go ahead :P
@fexd12 commented on GitHub (Apr 23, 2025):
Is there any update for this feature? If not, I can make a PR to bring the club id and player id.
@lorenzodb1 commented on GitHub (Apr 27, 2025):
I'm afraid I haven't found the time to integrate that code into soccerdata. If you or @MartiONE would like to work on it then please go ahead and do so!
@fexd12 commented on GitHub (Apr 29, 2025):
Glad to hear, i'm finishing some things in the code and i will open a PR in a couple days
@fexd12 commented on GitHub (May 2, 2025):
I have created the PR #827.
Check if needed something and let me know.
@jknight56 commented on GitHub (Jan 15, 2026):
This functionality would be extremely helpful for my pipeline. Can these additions be integrated? Please let me know if I can help anyway.