mirror of
https://github.com/probberechts/soccerdata.git
synced 2026-04-25 10:05:53 +03:00
[GH-ISSUE #661] Feature Request: Assists, Key Passes, Yellow Cards, Red cards info in understat.read_player_match_stats() #132
Labels
No labels
ESPN
FBref
FotMob
MatchHistory
SoFIFA
Sofascore
WhoScored
WhoScored
bug
build
common
dependencies
discussion
documentation
duplicate
enhancement
good first issue
invalid
performance
pull-request
question
question
removal
understat
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/soccerdata#132
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @babu-akhil on GitHub (Aug 4, 2024).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/661
Is there any reason why these columns are not included? I needed them and was able to add them for my requirement. If you think this is a good change to have to the library, I'd like to contribute this small change through a PR.
Thanks!
@probberechts commented on GitHub (Aug 4, 2024):
Yes, it would be great if you could create a PR for this.
@babu-akhil commented on GitHub (Aug 4, 2024):
Question: Do I need to run the nox test suite for all the python versions, i.e. for 3.8 -> 3.11 ? I am currently using 3.9 in my environment
@probberechts commented on GitHub (Aug 4, 2024):
If you create a PR, it will automatically run the tests for all Python versions. No need to install all of them locally.
@babu-akhil commented on GitHub (Aug 15, 2024):
Closing issue as feature merged