[GH-ISSUE #661] Feature Request: Assists, Key Passes, Yellow Cards, Red cards info in understat.read_player_match_stats() #132

Closed
opened 2026-03-02 15:56:03 +03:00 by kerem · 4 comments
Owner

Originally created by @babu-akhil on GitHub (Aug 4, 2024).
Original GitHub issue: https://github.com/probberechts/soccerdata/issues/661

Is there any reason why these columns are not included? I needed them and was able to add them for my requirement. If you think this is a good change to have to the library, I'd like to contribute this small change through a PR.

Thanks!

Originally created by @babu-akhil on GitHub (Aug 4, 2024). Original GitHub issue: https://github.com/probberechts/soccerdata/issues/661 Is there any reason why these columns are not included? I needed them and was able to add them for my requirement. If you think this is a good change to have to the library, I'd like to contribute this small change through a PR. Thanks!
kerem 2026-03-02 15:56:03 +03:00
Author
Owner

@probberechts commented on GitHub (Aug 4, 2024):

Yes, it would be great if you could create a PR for this.

<!-- gh-comment-id:2267488007 --> @probberechts commented on GitHub (Aug 4, 2024): Yes, it would be great if you could create a PR for this.
Author
Owner

@babu-akhil commented on GitHub (Aug 4, 2024):

Question: Do I need to run the nox test suite for all the python versions, i.e. for 3.8 -> 3.11 ? I am currently using 3.9 in my environment

<!-- gh-comment-id:2267510693 --> @babu-akhil commented on GitHub (Aug 4, 2024): Question: Do I need to run the nox test suite for all the python versions, i.e. for 3.8 -> 3.11 ? I am currently using 3.9 in my environment
Author
Owner

@probberechts commented on GitHub (Aug 4, 2024):

If you create a PR, it will automatically run the tests for all Python versions. No need to install all of them locally.

<!-- gh-comment-id:2267525944 --> @probberechts commented on GitHub (Aug 4, 2024): If you create a PR, it will automatically run the tests for all Python versions. No need to install all of them locally.
Author
Owner

@babu-akhil commented on GitHub (Aug 15, 2024):

Closing issue as feature merged

<!-- gh-comment-id:2291345248 --> @babu-akhil commented on GitHub (Aug 15, 2024): Closing issue as feature merged
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/soccerdata#132
No description provided.