starred/smtprelay
1
0
Fork 0
mirror of https://github.com/decke/smtprelay.git synced 2026-04-26 05:15:52 +03:00
Code Issues 7 Projects Releases 10 Packages Wiki Activity

[PR #230] [MERGED] Cleanup getTLSConfig() and also remove custom cipher list #226

New issue
Closed
opened 2026-02-26 18:33:51 +03:00 by kerem · 0 comments
kerem commented 2026-02-26 18:33:51 +03:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/decke/smtprelay/pull/230
Author: @decke
Created: 8/5/2025
Status: ✅ Merged
Merged: 8/5/2025
Merged by: @decke

Base: master ← Head: cleanup-tls-cyphers

📝 Commits (1)

  • 840047c Cleanup getTLSConfig() and also remove custom cipher list

📊 Changes

1 file changed (+1 additions, -20 deletions)

View changed files

📝 main.go (+1 -20)

📄 Description

With modern Go (>=1.17) this is mostly a NOOP except CBC ciphers/ LUCKY13. Since Go has mitigations against LUCKY13 this in fact improves our client compatbility and is safe to use.

See: https://github.com/golang/go/issues/13385

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/decke/smtprelay/pull/230 **Author:** [@decke](https://github.com/decke) **Created:** 8/5/2025 **Status:** ✅ Merged **Merged:** 8/5/2025 **Merged by:** [@decke](https://github.com/decke) **Base:** `master` ← **Head:** `cleanup-tls-cyphers` --- ### 📝 Commits (1) - [`840047c`](https://github.com/decke/smtprelay/commit/840047c1261a36be3e26156ddad0fed8a84e3c70) Cleanup getTLSConfig() and also remove custom cipher list ### 📊 Changes **1 file changed** (+1 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+1 -20) </details> ### 📄 Description With modern Go (>=1.17) this is mostly a NOOP except CBC ciphers/ LUCKY13. Since Go has mitigations against LUCKY13 this in fact improves our client compatbility and is safe to use. See: https://github.com/golang/go/issues/13385 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 18:33:51 +03:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/github.com/rs/zerolog-1.35.1
dependabot/go_modules/github.com/DeRuina/timberjack-1.4.2
dependabot/go_modules/github.com/chrj/smtpd-1.0.0
dependabot/github_actions/step-security/harden-runner-2.19.0
dependabot/github_actions/github/codeql-action-4.35.2
add-service
v1.13.2
v1.13.1
v1.13.0
v1.12.0
v1.11.2
v1.11.1
v1.11.0
v1.10.0
v1.9.0
v1.8.0
v1.7.0
v1.6.0
v1.5.0
v1.4.0
v1.3.0
v1.2.0
v1.1.0
v1.0.1
v1.0.0
Labels
Clear labels   
bug

   
pull-request

Mirrored from GitHub Pull Request

No labels
bug
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/smtprelay#226
No description provided.