[PR #780] Encrypt backed up messages #986

New issue

Open

opened 2026-02-26 01:32:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:32:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jberkel/sms-backup-plus/pull/780
Author: @ashh87
Created: 8/16/2017
Status: 🔄 Open

Base: master ← Head: master

📝 Commits (9)

5dbb615 use jcenter openpgp-api
e5091c1 Allow encrypting SMS messages
b02ddf9 Merge master, fix conflicts.
57d913c Upgrade pgp api in pom, add it to gradle.
795a5ec Move string to strigs xml
addf2bc Tell roboelectric where to find openpgp library in maven build.
5e467e1 Clean between builds, so roboelectric doesn't pick up on library unpacked by maven when run from gradle.
9c924ad Merge upstream
ae1d336 Merge upstream, fix conflicts. Untested as doesn't compile due to dialogpreference incompatibility (?)

📊 Changes

14 files changed (+207 additions, -12 deletions)

View changed files

📝 app/build.gradle (+1 -0)
📝 app/src/main/java/com/zegoggles/smssync/activity/MainActivity.java (+1 -0)
📝 app/src/main/java/com/zegoggles/smssync/activity/fragments/AdvancedSettings.java (+67 -0)
📝 app/src/main/java/com/zegoggles/smssync/mail/MessageConverter.java (+7 -2)
📝 app/src/main/java/com/zegoggles/smssync/mail/MessageGenerator.java (+41 -2)
📝 app/src/main/java/com/zegoggles/smssync/preferences/Preferences.java (+25 -0)
📝 app/src/main/java/com/zegoggles/smssync/service/BackupTask.java (+21 -2)
📝 app/src/main/java/com/zegoggles/smssync/service/SmsRestoreService.java (+2 -1)
📝 app/src/main/res/values/strings.xml (+9 -0)
📝 app/src/main/res/xml/preferences.xml (+17 -0)
📝 app/src/test/java/com/zegoggles/smssync/mail/MessageConverterTest.java (+4 -4)
📝 app/src/test/java/com/zegoggles/smssync/mail/MessageGeneratorTest.java (+8 -0)
📝 app/src/test/java/com/zegoggles/smssync/service/BackupTaskTest.java (+3 -1)
📝 app/src/test/resources/robolectric.properties (+1 -0)

📄 Description

These patches allow using the openpgp android API to encrypt backed up messages (SMS only, no decryption on restore).

I've been using these patches for years. I've taken the experimental decryption stuff out from my old git repo, as I haven't had a chance to finish it, and have never really needed it. Maybe I'll get round to it some day, as well as encrypting MMS messages! Most important to me is SMS encryption though, because it prevents a compromised email address being used to get round two-factor authentication or account recovery using SMS for any other service which knows the user's phone number.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jberkel/sms-backup-plus/pull/780 **Author:** [@ashh87](https://github.com/ashh87) **Created:** 8/16/2017 **Status:** 🔄 Open **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`5dbb615`](https://github.com/jberkel/sms-backup-plus/commit/5dbb615d655723749da3379b4adeec7c0a6a8e4b) use jcenter openpgp-api - [`e5091c1`](https://github.com/jberkel/sms-backup-plus/commit/e5091c1e7b5b1d95a904e0c4ee6c9cbeffaa1f6f) Allow encrypting SMS messages - [`b02ddf9`](https://github.com/jberkel/sms-backup-plus/commit/b02ddf9f7543bb2b072ce7b6a5d70443513457e6) Merge master, fix conflicts. - [`57d913c`](https://github.com/jberkel/sms-backup-plus/commit/57d913c1e9bc3cbb4c37c6637a9406725d9aff76) Upgrade pgp api in pom, add it to gradle. - [`795a5ec`](https://github.com/jberkel/sms-backup-plus/commit/795a5ec3dea5e193ac4611d1871e1961b16a175d) Move string to strigs xml - [`addf2bc`](https://github.com/jberkel/sms-backup-plus/commit/addf2bc9e268aeaaff202d2cf3d4720f7f7713ad) Tell roboelectric where to find openpgp library in maven build. - [`5e467e1`](https://github.com/jberkel/sms-backup-plus/commit/5e467e111c53d6ce5e62a8bbf1bd635aa9c62d39) Clean between builds, so roboelectric doesn't pick up on library unpacked by maven when run from gradle. - [`9c924ad`](https://github.com/jberkel/sms-backup-plus/commit/9c924addcfa4362867f808b1a57e76f42ed1d816) Merge upstream - [`ae1d336`](https://github.com/jberkel/sms-backup-plus/commit/ae1d336c2b59443a934ffeb37c5d0e5e22354ac6) Merge upstream, fix conflicts. Untested as doesn't compile due to dialogpreference incompatibility (?) ### 📊 Changes **14 files changed** (+207 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle` (+1 -0) 📝 `app/src/main/java/com/zegoggles/smssync/activity/MainActivity.java` (+1 -0) 📝 `app/src/main/java/com/zegoggles/smssync/activity/fragments/AdvancedSettings.java` (+67 -0) 📝 `app/src/main/java/com/zegoggles/smssync/mail/MessageConverter.java` (+7 -2) 📝 `app/src/main/java/com/zegoggles/smssync/mail/MessageGenerator.java` (+41 -2) 📝 `app/src/main/java/com/zegoggles/smssync/preferences/Preferences.java` (+25 -0) 📝 `app/src/main/java/com/zegoggles/smssync/service/BackupTask.java` (+21 -2) 📝 `app/src/main/java/com/zegoggles/smssync/service/SmsRestoreService.java` (+2 -1) 📝 `app/src/main/res/values/strings.xml` (+9 -0) 📝 `app/src/main/res/xml/preferences.xml` (+17 -0) 📝 `app/src/test/java/com/zegoggles/smssync/mail/MessageConverterTest.java` (+4 -4) 📝 `app/src/test/java/com/zegoggles/smssync/mail/MessageGeneratorTest.java` (+8 -0) 📝 `app/src/test/java/com/zegoggles/smssync/service/BackupTaskTest.java` (+3 -1) 📝 `app/src/test/resources/robolectric.properties` (+1 -0) </details> ### 📄 Description These patches allow using the openpgp android API to encrypt backed up messages (SMS only, no decryption on restore). I've been using these patches for years. I've taken the experimental decryption stuff out from my old git repo, as I haven't had a chance to finish it, and have never really needed it. Maybe I'll get round to it some day, as well as encrypting MMS messages! Most important to me is SMS encryption though, because it prevents a compromised email address being used to get round two-factor authentication or account recovery using SMS for any other service which knows the user's phone number. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>