mirror of
https://github.com/jberkel/sms-backup-plus.git
synced 2026-04-25 17:05:59 +03:00
[PR #388] [CLOSED] [NOT A PULL REQUEST] Request SMS Backup+ to be the default SMS package before restoring #955
Labels
No labels
AM+RCS
FAQ
awaiting response
backup
bespoke
bug
calendar
call log
cannot reproduce
cloudless
device-specific
documentation
dual- & multi-SIM
duplicate
feature-request
fixed in beta
good first issue
half-missing
help wanted
helpful
meta
misattribution
mms
other message sources
pull-request
question
rejuvenation
restore
schedule
security
stale
task
thanks
v1.5.1
v1.5.10
v1.5.11
v1.5.2
v1.5.3
v1.5.3
v1.5.4
v1.5.4
v1.5.5
v1.5.5
v1.5.6
v1.5.7
v1.5.8
v1.5.9
v1.6β
xoauth
~$ bounty $~
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/sms-backup-plus-jberkel#955
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/jberkel/sms-backup-plus/pull/388
Author: @beverloo
Created: 11/4/2013
Status: ❌ Closed
Base:
master← Head:master📝 Commits (1)
50f9a0eRequest SMS Backup+ to be set as the default SMS package before restoring.📊 Changes
6 files changed (+107 additions, -5 deletions)
View changed files
📝
AndroidManifest.xml(+45 -0)📝
build.gradle(+2 -2)📝
pom.xml(+2 -2)📝
src/com/zegoggles/smssync/Consts.java(+6 -0)📝
src/com/zegoggles/smssync/activity/MainActivity.java(+19 -1)📝
src/com/zegoggles/smssync/service/SmsRestoreService.java(+33 -0)📄 Description
Request SMS Backup+ to be set as the default SMS package before restoring.
THIS PATCH HAS A NUMBER OF TODOS AND SHOULD NOT LAND AS IS.
Starting with Android KitKat, only the default SMS package is allowed to
write to the SMS provider. Because SMS Backup+ did not register for the
ComposeSmsActivity activity or the receivers at all, it could not be set
as such, rendering the restore functionality useless in KitKat.
This patch somewhat hacks the necessary functionality in the application to
make it possible to import SMS messages again. It adds the necessary
receivers and activity to the AndroidManifest.xml file (but does not become
the default SMS app by default) and adds some logic to the restore flow:
if the user is running KitKat or higher and it's not already.
which we're launching the service.
to the SMS provider. A better message should be added here.
extra has been set. If so, ask the user to restore to that activity.
It's important to reset the default SMS provider to something that's not
SMS Backup+, because otherwise incoming messages will disappear in a black
hole. There's a lot of user interaction involved here, but I'm not sure if
there's a good way around that.
This patch is not ready to land, but I hope it gives you a good idea about
what's needed to fix restore for Android KitKat and higher. It allowed me
to import my SMS messages just fine :-). Thanks for the great app!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.