[PR #48] [MERGED] Some cleanups #897

New issue

Closed

opened 2026-02-26 01:32:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:32:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jberkel/sms-backup-plus/pull/48
Author: @bjdodson
Created: 10/1/2010
Status: ✅ Merged
Merged: 10/3/2010
Merged by: @undefined

Base: master ← Head: master

📝 Commits (2)

7594c3e improved contacts lookup
6f6aa83 runtime switch for pre and post eclair

📊 Changes

2 files changed (+47 additions, -17 deletions)

View changed files

📝 src/com/zegoggles/smssync/CursorToMessage.java (+46 -16)
📝 src/com/zegoggles/smssync/SmsBackupService.java (+1 -1)

📄 Description

Hi,

First off, thanks for your additions to sms backup. I love the app.

I was having a few problems that I think I've fixed:

Contacts were failing lookup entirely (not even a name was returned even when it was available). I fixed this by using the ContactsContract API introduced in api level 5, and in particular use the "highly optimized" query by phone number. I assume the optimization is that it converts things to a canonical representation before lookup.
Fixed a bug with looking up your own email address. Now uses the OAuth entry rather than the (unavailable) hardcoded username.

Thanks again for your work, I hope you find this useful.

Ben

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jberkel/sms-backup-plus/pull/48 **Author:** [@bjdodson](https://github.com/bjdodson) **Created:** 10/1/2010 **Status:** ✅ Merged **Merged:** 10/3/2010 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`7594c3e`](https://github.com/jberkel/sms-backup-plus/commit/7594c3e59d8621dd80b5ea7b38b6487cf87d8063) improved contacts lookup - [`6f6aa83`](https://github.com/jberkel/sms-backup-plus/commit/6f6aa835dc943374c8689795829ec6efe0319785) runtime switch for pre and post eclair ### 📊 Changes **2 files changed** (+47 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/com/zegoggles/smssync/CursorToMessage.java` (+46 -16) 📝 `src/com/zegoggles/smssync/SmsBackupService.java` (+1 -1) </details> ### 📄 Description Hi, First off, thanks for your additions to sms backup. I love the app. I was having a few problems that I think I've fixed: - Contacts were failing lookup entirely (not even a name was returned even when it was available). I fixed this by using the ContactsContract API introduced in api level 5, and in particular use the "highly optimized" query by phone number. I assume the optimization is that it converts things to a canonical representation before lookup. - Fixed a bug with looking up your own email address. Now uses the OAuth entry rather than the (unavailable) hardcoded username. Thanks again for your work, I hope you find this useful. Ben --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>