mirror of
https://github.com/jberkel/sms-backup-plus.git
synced 2026-04-25 17:05:59 +03:00
[GH-ISSUE #615] Call Log Backup duplicates #525
Labels
No labels
AM+RCS
FAQ
awaiting response
backup
bespoke
bug
calendar
call log
cannot reproduce
cloudless
device-specific
documentation
dual- & multi-SIM
duplicate
feature-request
fixed in beta
good first issue
half-missing
help wanted
helpful
meta
misattribution
mms
other message sources
pull-request
question
rejuvenation
restore
schedule
security
stale
task
thanks
v1.5.1
v1.5.10
v1.5.11
v1.5.2
v1.5.3
v1.5.3
v1.5.4
v1.5.4
v1.5.5
v1.5.5
v1.5.6
v1.5.7
v1.5.8
v1.5.9
v1.6β
xoauth
~$ bounty $~
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/sms-backup-plus-jberkel#525
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jas4711 on GitHub (Nov 27, 2015).
Original GitHub issue: https://github.com/jberkel/sms-backup-plus/issues/615
The duplicate check process when taking backups appears a bit fragile. In my "Call Log" folder (not to gmail, to my own IMAP server, if that makes a difference), I have the same call being backed up with subject line of "Call with Foo Bar", "Samtal med Foo Bar" (in Swedish, my normal system language), and "Samtal med 0123456789" (phone# of Foo Bar). Would it be possible for the app to be a bit smarter about this?
I assume my usage scenario is relevant: I re-install my phone once in a while, and rely on SMS Backup+ to restore the SMS/Call Logs from the earlier phone, and then set it up to perform backups going forward. I assume the problem happens during the initial restore and initial backup situation.
Either the duplicate check should be based on a stable property (Message-Id?) or it should recognize all Subject lines, or something. I don't really know how the logic works, so it is difficult to propose a solution.
@jberkel commented on GitHub (Feb 7, 2016):
Message ids are based on date, phone number and message type. Can you check if the message ids are different?
github.com/jberkel/sms-backup-plus@edb5f412de/src/main/java/com/zegoggles/smssync/mail/HeaderGenerator.java (L102-L102)