mirror of
https://github.com/jberkel/sms-backup-plus.git
synced 2026-04-25 17:05:59 +03:00
[GH-ISSUE #496] Inconsistent state when phone sleeps during restore #421
Labels
No labels
AM+RCS
FAQ
awaiting response
backup
bespoke
bug
calendar
call log
cannot reproduce
cloudless
device-specific
documentation
dual- & multi-SIM
duplicate
feature-request
fixed in beta
good first issue
half-missing
help wanted
helpful
meta
misattribution
mms
other message sources
pull-request
question
rejuvenation
restore
schedule
security
stale
task
thanks
v1.5.1
v1.5.10
v1.5.11
v1.5.2
v1.5.3
v1.5.3
v1.5.4
v1.5.4
v1.5.5
v1.5.5
v1.5.6
v1.5.7
v1.5.8
v1.5.9
v1.6β
xoauth
~$ bounty $~
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/sms-backup-plus-jberkel#421
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @davidchisnall on GitHub (Nov 16, 2014).
Original GitHub issue: https://github.com/jberkel/sms-backup-plus/issues/496
If the phone goes to sleep before a restore finishes then the 'switch SMS app back to Messages' box doesn't appear and, if you switch it back manually, then it only shows some messages - in my case only ones from August 2012 and earlier (my last backup was March 2014). Running restore again and poking the screen periodically to prevent it sleeping seemed to fix everything and my most recent SMS reappeared, but it would be good if users didn't have this 'where have all of my messages gone?!?' panic in the first place...
Presumably the same thing will happen if you lose network connectivity for some other reason.
@jberkel commented on GitHub (Nov 17, 2014):
yes, i'm a little bit worried, this default sms app switching is a huge hack, with lots of potential problems (message loss if the app is not switched back). But there's no clean way to do this, unless google adds new permissions.
@davidchisnall commented on GitHub (Nov 18, 2014):
You could solve this specific case by asking for the permission to prevent the phone from sleeping and do that while doing the restore. It wouldn't solve the problem of the network going away, but stashing a local copy of the SMS history before doing anything potentially destructive would at least allow you to restore it if the app crashed or the network died.
@jberkel commented on GitHub (Nov 18, 2014):
ok, currently restore/backup operations already hold a wakelock, but it's only a partial one. maybe it should be enough to convert it to a FULL wakelock for restore, i'll try that.
@jberkel commented on GitHub (Nov 18, 2014):
done in
github.com/jberkel/sms-backup-plus@6b70acd100@jberkel commented on GitHub (Nov 18, 2014):
there's a beta now which holds a full wake lock: https://github.com/jberkel/sms-backup-plus/releases/tag/1.5.6-BETA4
@jberkel commented on GitHub (Nov 21, 2014):
closing this, reopen if it didn't work