[PR #1080] added changes for multisim, added tests #1026

New issue

Open

opened 2026-02-26 01:32:40 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:32:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jberkel/sms-backup-plus/pull/1080
Author: @Cyber1000
Created: 5/28/2022
Status: 🔄 Open

Base: master ← Head: Cyber1000-multisim

📝 Commits (4)

9ed193f Add support for Multi-SIM, with tests
ba23197 Merge branch 'jberkel:master' into Cyber1000-multisim
f27fb5e still need READ_PHONE_STATE on higher versions not READ_PHONE_NUMBERS
e1a2b3b made queries safe for single SIMs

📊 Changes

43 files changed (+1044 additions, -384 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+3 -0)
📝 app/src/main/java/com/zegoggles/smssync/App.java (+5 -0)
📝 app/src/main/java/com/zegoggles/smssync/activity/MainActivity.java (+27 -5)
📝 app/src/main/java/com/zegoggles/smssync/activity/StatusPreference.java (+8 -2)
📝 app/src/main/java/com/zegoggles/smssync/activity/fragments/AdvancedSettings.java (+164 -19)
📝 app/src/main/java/com/zegoggles/smssync/activity/fragments/MainSettings.java (+44 -3)
📝 app/src/main/java/com/zegoggles/smssync/activity/fragments/SMSBackupPreferenceFragment.java (+28 -0)
📝 app/src/main/java/com/zegoggles/smssync/mail/BackupImapStore.java (+2 -2)
📝 app/src/main/java/com/zegoggles/smssync/mail/DataType.java (+2 -2)
📝 app/src/main/java/com/zegoggles/smssync/mail/MessageConverter.java (+20 -3)
📝 app/src/main/java/com/zegoggles/smssync/mail/MessageGenerator.java (+12 -12)
📝 app/src/main/java/com/zegoggles/smssync/preferences/AuthPreferences.java (+35 -13)
📝 app/src/main/java/com/zegoggles/smssync/preferences/DataTypePreferences.java (+16 -12)
📝 app/src/main/java/com/zegoggles/smssync/preferences/Defaults.java (+1 -0)
📝 app/src/main/java/com/zegoggles/smssync/preferences/Preferences.java (+17 -8)
📝 app/src/main/java/com/zegoggles/smssync/receiver/SmsBroadcastReceiver.java (+8 -4)
📝 app/src/main/java/com/zegoggles/smssync/service/BackupConfig.java (+19 -8)
📝 app/src/main/java/com/zegoggles/smssync/service/BackupItemsFetcher.java (+2 -2)
📝 app/src/main/java/com/zegoggles/smssync/service/BackupQueryBuilder.java (+46 -17)
📝 app/src/main/java/com/zegoggles/smssync/service/BackupTask.java (+90 -53)

...and 23 more files

📄 Description

Added support for multisim (see #598):

if multisim you now have multiple entries at some places (see screenshots)
at this places the phone-number will be displayed (43...) in the screenshot (therefore sms-backup+ needs more rights)
- if you have only one sim, your phone number won't be displayed (everything stays the same)
you can takeover imapsettings from sim 1 (see screenshot)
I had one problem how callog is assigned to the phonenumber:
- some phones use a continuous number like 1, 2 - like my old honor
- some phones use the IccId (kind of sim-card-number) like my current Samsung
- this is no problem with backup (I just search for both), but maybe a problem for restore, thus the setting (see screenshot). This needs to be set by the user depending on his phone
There were some places in code with XOAuth2, I didn't take that into account (at least not everywhere), since it is no longer supported
New texts are English and German (no other translations)
added tests
tried it on my Samsung (currently Android 10, but will update to Android 11 soon)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jberkel/sms-backup-plus/pull/1080 **Author:** [@Cyber1000](https://github.com/Cyber1000) **Created:** 5/28/2022 **Status:** 🔄 Open **Base:** `master` ← **Head:** `Cyber1000-multisim` --- ### 📝 Commits (4) - [`9ed193f`](https://github.com/jberkel/sms-backup-plus/commit/9ed193ff317d37e5425b3844aff0d1abcc82852b) Add support for Multi-SIM, with tests - [`ba23197`](https://github.com/jberkel/sms-backup-plus/commit/ba23197d6541f51c33f94249f0fc6cbdca588522) Merge branch 'jberkel:master' into Cyber1000-multisim - [`f27fb5e`](https://github.com/jberkel/sms-backup-plus/commit/f27fb5e3105952a6384596d14d25db4f3648a5b3) still need READ_PHONE_STATE on higher versions not READ_PHONE_NUMBERS - [`e1a2b3b`](https://github.com/jberkel/sms-backup-plus/commit/e1a2b3bf29a4d758bec59c9fd68e6deba336bcd7) made queries safe for single SIMs ### 📊 Changes **43 files changed** (+1044 additions, -384 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+3 -0) 📝 `app/src/main/java/com/zegoggles/smssync/App.java` (+5 -0) 📝 `app/src/main/java/com/zegoggles/smssync/activity/MainActivity.java` (+27 -5) 📝 `app/src/main/java/com/zegoggles/smssync/activity/StatusPreference.java` (+8 -2) 📝 `app/src/main/java/com/zegoggles/smssync/activity/fragments/AdvancedSettings.java` (+164 -19) 📝 `app/src/main/java/com/zegoggles/smssync/activity/fragments/MainSettings.java` (+44 -3) 📝 `app/src/main/java/com/zegoggles/smssync/activity/fragments/SMSBackupPreferenceFragment.java` (+28 -0) 📝 `app/src/main/java/com/zegoggles/smssync/mail/BackupImapStore.java` (+2 -2) 📝 `app/src/main/java/com/zegoggles/smssync/mail/DataType.java` (+2 -2) 📝 `app/src/main/java/com/zegoggles/smssync/mail/MessageConverter.java` (+20 -3) 📝 `app/src/main/java/com/zegoggles/smssync/mail/MessageGenerator.java` (+12 -12) 📝 `app/src/main/java/com/zegoggles/smssync/preferences/AuthPreferences.java` (+35 -13) 📝 `app/src/main/java/com/zegoggles/smssync/preferences/DataTypePreferences.java` (+16 -12) 📝 `app/src/main/java/com/zegoggles/smssync/preferences/Defaults.java` (+1 -0) 📝 `app/src/main/java/com/zegoggles/smssync/preferences/Preferences.java` (+17 -8) 📝 `app/src/main/java/com/zegoggles/smssync/receiver/SmsBroadcastReceiver.java` (+8 -4) 📝 `app/src/main/java/com/zegoggles/smssync/service/BackupConfig.java` (+19 -8) 📝 `app/src/main/java/com/zegoggles/smssync/service/BackupItemsFetcher.java` (+2 -2) 📝 `app/src/main/java/com/zegoggles/smssync/service/BackupQueryBuilder.java` (+46 -17) 📝 `app/src/main/java/com/zegoggles/smssync/service/BackupTask.java` (+90 -53) _...and 23 more files_ </details> ### 📄 Description Added support for multisim (see #598): - if multisim you now have multiple entries at some places (see screenshots) - at this places the phone-number will be displayed (43...) in the screenshot (therefore sms-backup+ needs more rights) - if you have only one sim, your phone number won't be displayed (everything stays the same) - you can takeover imapsettings from sim 1 (see screenshot) - I had one problem how callog is assigned to the phonenumber: - some phones use a continuous number like 1, 2 - like my old honor - some phones use the IccId (kind of sim-card-number) like my current Samsung - this is no problem with backup (I just search for both), but maybe a problem for restore, thus the setting (see screenshot). This needs to be set by the user depending on his phone - There were some places in code with XOAuth2, I didn't take that into account (at least not everywhere), since it is no longer supported - New texts are English and German (no other translations) - added tests - tried it on my Samsung (currently Android 10, but will update to Android 11 soon) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>