[PR #994] [MERGED] Fix a too specific error string about IMAP failure #1015

New issue

Closed

opened 2026-02-26 01:32:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 01:32:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/jberkel/sms-backup-plus/pull/994
Author: @mdimjasevic
Created: 11/8/2019
Status: ✅ Merged
Merged: 12/6/2019
Merged by: @jberkel

Base: master ← Head: master

📝 Commits (2)

104933a Fix a too specific error string about IMAP failure
ec70b7a Fix a test expecting exact IMAP error message

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 app/src/main/res/values/strings.xml (+1 -1)
📝 app/src/test/java/com/zegoggles/smssync/service/state/StateTest.java (+1 -1)

📄 Description

I use my own IMAP server instead of GMail and I got a notification reading:

Temporary Gmail IMAP error, try again later.

I was confused at first. Then I realized that an assumption is that everyone uses GMail, even though the app works just fine with any other IMAP server.

This error message is too specific as it applies to a failure with any IMAP server, and not just GMail. The patch makes the message more general, which makes it applicable to all app users.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/jberkel/sms-backup-plus/pull/994 **Author:** [@mdimjasevic](https://github.com/mdimjasevic) **Created:** 11/8/2019 **Status:** ✅ Merged **Merged:** 12/6/2019 **Merged by:** [@jberkel](https://github.com/jberkel) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`104933a`](https://github.com/jberkel/sms-backup-plus/commit/104933a940935cbec6bff026043db8a34944a270) Fix a too specific error string about IMAP failure - [`ec70b7a`](https://github.com/jberkel/sms-backup-plus/commit/ec70b7a723c6e49ae6ef989d4138b4aea7ff6a19) Fix a test expecting exact IMAP error message ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/res/values/strings.xml` (+1 -1) 📝 `app/src/test/java/com/zegoggles/smssync/service/state/StateTest.java` (+1 -1) </details> ### 📄 Description I use my own IMAP server instead of GMail and I got a notification reading: Temporary Gmail IMAP error, try again later. I was confused at first. Then I realized that an assumption is that everyone uses GMail, even though the app works just fine with any other IMAP server. This error message is too specific as it applies to a failure with any IMAP server, and not just GMail. The patch makes the message more general, which makes it applicable to all app users. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>