[PR #1112] [MERGED] fix: parse pocket new CSV format #992

New issue

Closed

opened 2026-02-25 23:36:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:36:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1112
Author: @bakito
Created: 6/7/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @fmartingr

Base: master ← Head: csv

📝 Commits (5)

91ee775 fix pocket parsing error
b96640d Merge branch 'master' into csv
9f60c85 add tests forpocket csv
f8505d0 Use file name from test case
84f7e86 fix lint ant test issues

📊 Changes

4 files changed (+88 additions, -5 deletions)

View changed files

📝 internal/cmd/pocket.go (+8 -5)
➕ internal/cmd/pocket_test.go (+76 -0)
➕ testdata/pocket-new.csv (+2 -0)
➕ testdata/pocket-old.csv (+2 -0)

📄 Description

fixes: #1110

This PR fixes Pocket CSV Parsing errors, by not verifying the whole header line, but just finding the relevant colums and using these dynamic colum indexes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1112 **Author:** [@bakito](https://github.com/bakito) **Created:** 6/7/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `csv` --- ### 📝 Commits (5) - [`91ee775`](https://github.com/go-shiori/shiori/commit/91ee7752576d22c6c81bedd33c0f7e05f36d06c1) fix pocket parsing error - [`b96640d`](https://github.com/go-shiori/shiori/commit/b96640d4e3d7fca276ecb9ce4fef98c3256c31c4) Merge branch 'master' into csv - [`9f60c85`](https://github.com/go-shiori/shiori/commit/9f60c856aa9955eee2b6d9fbf3218cdaa3a3910e) add tests forpocket csv - [`f8505d0`](https://github.com/go-shiori/shiori/commit/f8505d091fca58d33a8c67cd66fc514651276584) Use file name from test case - [`84f7e86`](https://github.com/go-shiori/shiori/commit/84f7e8631ac4d15288c8bfb4c7d396dd940ce025) fix lint ant test issues ### 📊 Changes **4 files changed** (+88 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/pocket.go` (+8 -5) ➕ `internal/cmd/pocket_test.go` (+76 -0) ➕ `testdata/pocket-new.csv` (+2 -0) ➕ `testdata/pocket-old.csv` (+2 -0) </details> ### 📄 Description fixes: #1110 This PR fixes Pocket CSV Parsing errors, by not verifying the whole header line, but just finding the relevant colums and using these dynamic colum indexes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>