[PR #1064] [MERGED] refactor: remove gin and use stdlib http server #964

New issue

Closed

opened 2026-02-25 23:36:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:36:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1064
Author: @fmartingr
Created: 2/23/2025
Status: ✅ Merged
Merged: 2/26/2025
Merged by: @fmartingr

Base: master ← Head: refactor/api-stdlib

📝 Commits (10+)

d2c623f refactor: base http server stdlib
c541730 refactor: swagger and frontend routes
87f2904 fix: use global middlewares
f32e278 refactor: removed gin from testutils
3973a95 fix: object references in legacy webserver
8208df7 refactor: legacy, swagger and system handlers
4531434 fix: added verbs to handlers
4affe8a fix: server handlers ordering
875db5f refactor: bookmarks handlers
d09402f refactor: system api routes

📊 Changes

123 files changed (+5153 additions, -3884 deletions)

View changed files

📝 docs/swagger/docs.go (+93 -73)
📝 docs/swagger/swagger.json (+93 -73)
📝 docs/swagger/swagger.yaml (+66 -52)
📝 e2e/playwright/accounts_test.go (+1 -1)
📝 e2e/playwright/reporter.go (+0 -1)
📝 go.mod (+2 -24)
📝 go.sum (+4 -65)
📝 internal/cmd/add.go (+3 -3)
📝 internal/cmd/check.go (+2 -3)
📝 internal/cmd/delete.go (+1 -1)
📝 internal/cmd/export.go (+1 -2)
📝 internal/cmd/import.go (+9 -5)
📝 internal/cmd/open.go (+3 -3)
📝 internal/cmd/pocket.go (+11 -10)
📝 internal/cmd/print.go (+5 -5)
📝 internal/cmd/root.go (+11 -10)
📝 internal/cmd/server.go (+5 -5)
📝 internal/cmd/update.go (+7 -6)
📝 internal/core/ebook.go (+6 -7)
📝 internal/core/ebook_test.go (+10 -10)

...and 80 more files

📄 Description

Remove gin dependency. and use the stdlib http server
Created new WebContext and HttpHandler to use and main http handler helpers for the server
Refactored the Dependencies and other objects to have interfaces to prevent import cycles

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1064 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 2/23/2025 **Status:** ✅ Merged **Merged:** 2/26/2025 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `refactor/api-stdlib` --- ### 📝 Commits (10+) - [`d2c623f`](https://github.com/go-shiori/shiori/commit/d2c623f48ee99a254352b72f37c399588927ef29) refactor: base http server stdlib - [`c541730`](https://github.com/go-shiori/shiori/commit/c5417309e5ceb82ee3cafa9dea6235419db534eb) refactor: swagger and frontend routes - [`87f2904`](https://github.com/go-shiori/shiori/commit/87f2904d6da60a656d21055d8a52bc625714c666) fix: use global middlewares - [`f32e278`](https://github.com/go-shiori/shiori/commit/f32e278647b911164e41271b77c89c7f48d4115d) refactor: removed gin from testutils - [`3973a95`](https://github.com/go-shiori/shiori/commit/3973a95f0d0ab262490055fcc0be74025683a12b) fix: object references in legacy webserver - [`8208df7`](https://github.com/go-shiori/shiori/commit/8208df757d9fd06c555b64868d08608a84ffcc1c) refactor: legacy, swagger and system handlers - [`4531434`](https://github.com/go-shiori/shiori/commit/45314347ea147dfd2d924b07f720f9021da22de7) fix: added verbs to handlers - [`4affe8a`](https://github.com/go-shiori/shiori/commit/4affe8aedaa1f79d987e478a746d8d5c8bc71609) fix: server handlers ordering - [`875db5f`](https://github.com/go-shiori/shiori/commit/875db5fa111b83b179897bc673ec7fe940e48952) refactor: bookmarks handlers - [`d09402f`](https://github.com/go-shiori/shiori/commit/d09402fc278ba750ec7ee30598efcc43a8de421d) refactor: system api routes ### 📊 Changes **123 files changed** (+5153 additions, -3884 deletions) <details> <summary>View changed files</summary> 📝 `docs/swagger/docs.go` (+93 -73) 📝 `docs/swagger/swagger.json` (+93 -73) 📝 `docs/swagger/swagger.yaml` (+66 -52) 📝 `e2e/playwright/accounts_test.go` (+1 -1) 📝 `e2e/playwright/reporter.go` (+0 -1) 📝 `go.mod` (+2 -24) 📝 `go.sum` (+4 -65) 📝 `internal/cmd/add.go` (+3 -3) 📝 `internal/cmd/check.go` (+2 -3) 📝 `internal/cmd/delete.go` (+1 -1) 📝 `internal/cmd/export.go` (+1 -2) 📝 `internal/cmd/import.go` (+9 -5) 📝 `internal/cmd/open.go` (+3 -3) 📝 `internal/cmd/pocket.go` (+11 -10) 📝 `internal/cmd/print.go` (+5 -5) 📝 `internal/cmd/root.go` (+11 -10) 📝 `internal/cmd/server.go` (+5 -5) 📝 `internal/cmd/update.go` (+7 -6) 📝 `internal/core/ebook.go` (+6 -7) 📝 `internal/core/ebook_test.go` (+10 -10) _...and 80 more files_ </details> ### 📄 Description - Remove `gin` dependency. and use the stdlib http server - Created new `WebContext` and `HttpHandler` to use and main http handler helpers for the server - Refactored the `Dependencies` and other objects to have interfaces to prevent import cycles --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>