[GH-ISSUE #132] Windows builds are failing #96

New issue

Closed

opened 2026-02-25 23:33:26 +03:00 by kerem · 2 comments

kerem commented

2026-02-25 23:33:26 +03:00

Owner

Originally created by @hoijui on GitHub (May 15, 2019).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/132

.. because of a dependency that fails to build on windows.
I already submitted a pull-request there, that fixes it:
https://github.com/gosuri/uilive/pull/26

Originally created by @hoijui on GitHub (May 15, 2019). Original GitHub issue: https://github.com/go-shiori/shiori/issues/132 .. because of a dependency that fails to build on windows. I already submitted a pull-request there, that fixes it: https://github.com/gosuri/uilive/pull/26

kerem closed this issue

2026-02-25 23:33:26 +03:00

kerem commented

2026-02-25 23:33:26 +03:00

Author

Owner

@RadhiFadlillah commented on GitHub (Aug 27, 2019):

Since the ramadhan branch is merged, Shiori now doesn't use progress bar in CLI anymore, mostly because I think it feels buggy in several shells. Instead now we simply print the download progress on real time as it is :

Downloading article(s)...
[1/3] Downloaded https://www.theguardian.com/business/2019/may/21/trump-china-trade-war-us-economy-oecd-tariff
[2/3] Downloaded https://www.economist.com/leaders/2019/05/16/a-new-kind-of-cold-war
[3/3] Downloaded https://kotaku.com/the-spectacular-story-of-metroid-one-of-gamings-riche-1284029577
Download finished

IMHO this is better and more clear than progress bar. With that said, I think this issue has been fixed now so I will close this issue. Feel free to reopen it if needed.

@RadhiFadlillah commented on GitHub (Aug 27, 2019): Since the ramadhan branch is merged, Shiori now doesn't use progress bar in CLI anymore, mostly because I think it feels buggy in several shells. Instead now we simply print the download progress on real time as it is : ``` Downloading article(s)... [1/3] Downloaded https://www.theguardian.com/business/2019/may/21/trump-china-trade-war-us-economy-oecd-tariff [2/3] Downloaded https://www.economist.com/leaders/2019/05/16/a-new-kind-of-cold-war [3/3] Downloaded https://kotaku.com/the-spectacular-story-of-metroid-one-of-gamings-riche-1284029577 Download finished ``` IMHO this is better and more clear than progress bar. With that said, I think this issue has been fixed now so I will close this issue. Feel free to reopen it if needed.

kerem commented

2026-02-25 23:33:26 +03:00

Author

Owner

@hoijui commented on GitHub (Aug 27, 2019):

good work! and thanks. :-)

@hoijui commented on GitHub (Aug 27, 2019): good work! and thanks. :-)