[PR #1050] [MERGED] test: test all supported engines on their oldest supported releases #951

New issue

Closed

opened 2026-02-25 23:36:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:36:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1050
Author: @fmartingr
Created: 1/5/2025
Status: ✅ Merged
Merged: 1/5/2025
Merged by: @fmartingr

Base: master ← Head: test/database-engines-eol

📝 Commits (3)

82ed2e1 test: test all supported engines on their oldest supported releases
0871f31 update pre-hook file
8b12605 update mysql container options

📊 Changes

5 files changed (+78 additions, -35 deletions)

View changed files

📝 .githooks/pre-commit (+9 -2)
📝 .github/workflows/_test.yml (+17 -2)
📝 docker-compose.yaml (+12 -2)
📝 docs/Contribute.md (+7 -2)
📝 internal/database/mysql_test.go (+33 -27)

📄 Description

Modifies the docker compose and github workflow files to use the oldest supported database engines, adding mysql into de mix, so we can run the test suite against all of them, helping identifying database bugs earlier.

#1009

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1050 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 1/5/2025 **Status:** ✅ Merged **Merged:** 1/5/2025 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `test/database-engines-eol` --- ### 📝 Commits (3) - [`82ed2e1`](https://github.com/go-shiori/shiori/commit/82ed2e1a2fd24066b9c590b062f2bfadb6eb583f) test: test all supported engines on their oldest supported releases - [`0871f31`](https://github.com/go-shiori/shiori/commit/0871f31ec1d1c811eb64bb5ea4b2d399c43de3f4) update pre-hook file - [`8b12605`](https://github.com/go-shiori/shiori/commit/8b12605505b9dc713697adf53f1e55ad6fa1cb12) update mysql container options ### 📊 Changes **5 files changed** (+78 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.githooks/pre-commit` (+9 -2) 📝 `.github/workflows/_test.yml` (+17 -2) 📝 `docker-compose.yaml` (+12 -2) 📝 `docs/Contribute.md` (+7 -2) 📝 `internal/database/mysql_test.go` (+33 -27) </details> ### 📄 Description Modifies the docker compose and github workflow files to use the oldest supported database engines, adding mysql into de mix, so we can run the test suite against all of them, helping identifying database bugs earlier. #1009 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>