[PR #1049] [MERGED] fix: incorrectly set cookie's expires value in login.js #950

New issue

Closed

opened 2026-02-25 23:35:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1049
Author: @Promix953
Created: 1/2/2025
Status: ✅ Merged
Merged: 1/3/2025
Merged by: @fmartingr

Base: master ← Head: fix-cookie-expires

📝 Commits (1)

f0c9539 fix: incorrectly set cookie's expires value in login.js

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 internal/view/assets/js/component/login.js (+2 -2)

📄 Description

When writing a cookie using document.cookie, the expires value should use the UTCString format.

https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie#write_a_new_cookie

If expires is set incorrectly, the cookie will expire at the end of session and thumbnail will fail to load.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1049 **Author:** [@Promix953](https://github.com/Promix953) **Created:** 1/2/2025 **Status:** ✅ Merged **Merged:** 1/3/2025 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix-cookie-expires` --- ### 📝 Commits (1) - [`f0c9539`](https://github.com/go-shiori/shiori/commit/f0c953994014ee0ff006441a9beb862cb83a7167) fix: incorrectly set cookie's expires value in login.js ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/js/component/login.js` (+2 -2) </details> ### 📄 Description When writing a cookie using document.cookie, the expires value should use the UTCString format. https://developer.mozilla.org/en-US/docs/Web/API/Document/cookie#write_a_new_cookie If expires is set incorrectly, the cookie will expire at the end of session and thumbnail will fail to load. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>