[PR #1046] [MERGED] feat: fixes to webroot feature and improvements to development using it #946

New issue

Closed

opened 2026-02-25 23:35:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1046
Author: @fmartingr
Created: 1/1/2025
Status: ✅ Merged
Merged: 1/1/2025
Merged by: @fmartingr

Base: master ← Head: fix/webroot-dev

📝 Commits (4)

a0fca6a feat: Add nginx service to test shiori webroot configuration
c32f9a8 docs: Update contribution guide with server and docker instructions
c8febb1 docs: Add Docker and nginx documentation for local development
2f1f784 test: IsValid()

📊 Changes

8 files changed (+125 additions, -31 deletions)

View changed files

📝 Makefile (+0 -5)
📝 docker-compose.yaml (+20 -3)
📝 docs/Contribute.md (+30 -8)
📝 internal/cmd/root.go (+4 -0)
📝 internal/config/config.go (+16 -0)
📝 internal/config/config_test.go (+16 -0)
📝 internal/view/index.html (+15 -15)
➕ testdata/nginx.conf (+24 -0)

📄 Description

Fixes some issues regarding the usage of the RootPath configuration, including validation of the attribute requiring a slash at the end to avoid issues in configurations.

Also, added a nginx service to the development compose file to locally test this feature.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1046 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 1/1/2025 **Status:** ✅ Merged **Merged:** 1/1/2025 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/webroot-dev` --- ### 📝 Commits (4) - [`a0fca6a`](https://github.com/go-shiori/shiori/commit/a0fca6a0d7429baab42f9e4a32c2ae37df68a3e5) feat: Add nginx service to test shiori webroot configuration - [`c32f9a8`](https://github.com/go-shiori/shiori/commit/c32f9a85215eb47a9dd943e457c8ba8b25207e44) docs: Update contribution guide with server and docker instructions - [`c8febb1`](https://github.com/go-shiori/shiori/commit/c8febb179a2e3cb7f196d2d80c68614ef556beea) docs: Add Docker and nginx documentation for local development - [`2f1f784`](https://github.com/go-shiori/shiori/commit/2f1f784e300febaa3f1f7b91a7fcd31212ff8f80) test: IsValid() ### 📊 Changes **8 files changed** (+125 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+0 -5) 📝 `docker-compose.yaml` (+20 -3) 📝 `docs/Contribute.md` (+30 -8) 📝 `internal/cmd/root.go` (+4 -0) 📝 `internal/config/config.go` (+16 -0) 📝 `internal/config/config_test.go` (+16 -0) 📝 `internal/view/index.html` (+15 -15) ➕ `testdata/nginx.conf` (+24 -0) </details> ### 📄 Description Fixes some issues regarding the usage of the `RootPath` configuration, including validation of the attribute requiring a slash at the end to avoid issues in configurations. Also, added a `nginx` service to the development compose file to locally test this feature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>