[PR #1044] [MERGED] fix: login redirect not working properly after component refactor #945

New issue

Closed

opened 2026-02-25 23:35:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1044
Author: @fmartingr
Created: 12/31/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @fmartingr

Base: master ← Head: fix/login-redirect

📝 Commits (4)

1753fe9 feat: Add secure destination URL handling for login redirect
aa4c640 fix: rootpath on redirect to login
b74bd4b fixed tests
61c700d Merge branch 'master' into fix/login-redirect

📊 Changes

5 files changed (+53 additions, -9 deletions)

View changed files

📝 internal/http/response/shortcuts.go (+10 -2)
📝 internal/http/routes/bookmark.go (+1 -1)
📝 internal/http/routes/bookmark_test.go (+2 -1)
📝 internal/view/assets/js/component/login.js (+33 -0)
📝 internal/view/index.html (+7 -5)

📄 Description

Bug introduced in #1017

The login component was not properly handling the dst parameter, and the backend was redirecting to the (now non-existant) /logjn route.

Modified the backend to properly redirect to / when the user is not authenticated and added dst parameter support to the login component.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1044 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/login-redirect` --- ### 📝 Commits (4) - [`1753fe9`](https://github.com/go-shiori/shiori/commit/1753fe9ea88cc11706488d980d65a9fd99271788) feat: Add secure destination URL handling for login redirect - [`aa4c640`](https://github.com/go-shiori/shiori/commit/aa4c6406d11b994278e3b25c5407feb671ec80a0) fix: rootpath on redirect to login - [`b74bd4b`](https://github.com/go-shiori/shiori/commit/b74bd4b33c90b132fbb98e57865ece2fc91097ca) fixed tests - [`61c700d`](https://github.com/go-shiori/shiori/commit/61c700dd301b9dd2cd1a23372d6d524ee973bf6f) Merge branch 'master' into fix/login-redirect ### 📊 Changes **5 files changed** (+53 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `internal/http/response/shortcuts.go` (+10 -2) 📝 `internal/http/routes/bookmark.go` (+1 -1) 📝 `internal/http/routes/bookmark_test.go` (+2 -1) 📝 `internal/view/assets/js/component/login.js` (+33 -0) 📝 `internal/view/index.html` (+7 -5) </details> ### 📄 Description Bug introduced in #1017 The login component was not properly handling the `dst` parameter, and the backend was redirecting to the (now non-existant) `/logjn` route. Modified the backend to properly redirect to `/` when the user is not authenticated and added `dst` parameter support to the login component. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>