[PR #1023] [MERGED] feat: allow import of newer pocket data export files in csv format #932

New issue

Closed

opened 2026-02-25 23:35:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1023
Author: @melnary
Created: 12/9/2024
Status: ✅ Merged
Merged: 12/11/2024
Merged by: @fmartingr

Base: master ← Head: feat/pocket-csv-import

📝 Commits (5)

68e2e50 feat: allow import of newer pocket data export files in csv format
4362f49 Merge branch 'master' into feat/pocket-csv-import
c9a6d0d Merge branch 'master' into feat/pocket-csv-import
aefa312 Merge remote-tracking branch 'upstream/master' into feat/pocket-csv-import
2e5290a fix: linter error

📊 Changes

1 file changed (+144 additions, -43 deletions)

View changed files

📝 internal/cmd/pocket.go (+144 -43)

📄 Description

Recently Pocket changed the format of their data export function, switching from HTML files to a zipped folder containing CSV files, delivered in parts of up to 10000 bookmarks.
Other bookmark managers were also affected by this, as seen here: https://github.com/hoarder-app/hoarder/issues/570

This patch allows the pocket sub-command to handle these files correctly, expanding it's functionality to import both HTML and CSV files, as I believe the ability to import older exports may still be useful. This is done by a simple file extension check, which I think will suffice for most users.

Note that the command still does not process the multiple part files explicitly, so the user has to import them one by one, which I don't think will be too much of a hassle for the user either way. :)

I would appreciate it if someone could test this patch on an older HTML file (or give me one so I could test it myself :3), as I was only able to test it with my own CSV export.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1023 **Author:** [@melnary](https://github.com/melnary) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/11/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `feat/pocket-csv-import` --- ### 📝 Commits (5) - [`68e2e50`](https://github.com/go-shiori/shiori/commit/68e2e50ce57113e3074504ed7a537415396fa757) feat: allow import of newer pocket data export files in csv format - [`4362f49`](https://github.com/go-shiori/shiori/commit/4362f49f965fcbfe658530d64ab54d9ffb85ca1e) Merge branch 'master' into feat/pocket-csv-import - [`c9a6d0d`](https://github.com/go-shiori/shiori/commit/c9a6d0dbd9578c2e4d16c2bcf34e0ae378caae24) Merge branch 'master' into feat/pocket-csv-import - [`aefa312`](https://github.com/go-shiori/shiori/commit/aefa3125b4fc896edca30fd36d7b3bbf06246297) Merge remote-tracking branch 'upstream/master' into feat/pocket-csv-import - [`2e5290a`](https://github.com/go-shiori/shiori/commit/2e5290a7cfb77647ac73eb173bbc79cda556cd60) fix: linter error ### 📊 Changes **1 file changed** (+144 additions, -43 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/pocket.go` (+144 -43) </details> ### 📄 Description Recently Pocket changed the format of their data export function, switching from HTML files to a zipped folder containing CSV files, delivered in parts of up to 10000 bookmarks. Other bookmark managers were also affected by this, as seen here: https://github.com/hoarder-app/hoarder/issues/570 This patch allows the `pocket` sub-command to handle these files correctly, expanding it's functionality to import both HTML and CSV files, as I believe the ability to import older exports may still be useful. This is done by a simple file extension check, which I think will suffice for most users. Note that the command still does not process the multiple part files explicitly, so the user has to import them one by one, which I don't think will be too much of a hassle for the user either way. :) I would appreciate it if someone could test this patch on an older HTML file (or give me one so I could test it myself :3), as I was only able to test it with my own CSV export. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>