[PR #1022] [MERGED] fix: login component behavior when logging out and refreshing the page #931

Closed
opened 2026-02-25 23:35:56 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/1022
Author: @fmartingr
Created: 12/9/2024
Status: Merged
Merged: 12/9/2024
Merged by: @fmartingr

Base: masterHead: fix/login-refresh


📝 Commits (5)

  • 3e01379 fix: Validate session on login component mount to prevent unnecessary login form
  • 5e6b779 fix: Replace non-existent api/v1/auth/check with api/v1/auth/me
  • fe993cb feat: Prevent login form flickering by conditionally rendering only when needed
  • 711a9f6 feat: Show login component after user logout
  • aeb872d fix: make styles

📊 Changes

2 files changed (+33 additions, -7 deletions)

View changed files

📝 internal/view/assets/js/component/login.js (+26 -4)
📝 internal/view/index.html (+7 -3)

📄 Description

Summary

  • Preventing unnecessary login form display during page loads
  • Improving session validation
  • Fixes logout behavior

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/1022 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 12/9/2024 **Status:** ✅ Merged **Merged:** 12/9/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/login-refresh` --- ### 📝 Commits (5) - [`3e01379`](https://github.com/go-shiori/shiori/commit/3e0137938fc6c9844ba684dc63cc1688ff58a733) fix: Validate session on login component mount to prevent unnecessary login form - [`5e6b779`](https://github.com/go-shiori/shiori/commit/5e6b7794ddbb0c5a6ea6366578e1ac00f0a30a00) fix: Replace non-existent `api/v1/auth/check` with `api/v1/auth/me` - [`fe993cb`](https://github.com/go-shiori/shiori/commit/fe993cbd1e054d32eff5f34ae679ad7e9038176d) feat: Prevent login form flickering by conditionally rendering only when needed - [`711a9f6`](https://github.com/go-shiori/shiori/commit/711a9f67b110b48979abfbbd8497abd5f2e1a706) feat: Show login component after user logout - [`aeb872d`](https://github.com/go-shiori/shiori/commit/aeb872d467570e962c5b6920b6032e486592244c) fix: make styles ### 📊 Changes **2 files changed** (+33 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/assets/js/component/login.js` (+26 -4) 📝 `internal/view/index.html` (+7 -3) </details> ### 📄 Description #### Summary - Preventing unnecessary login form display during page loads - Improving session validation - Fixes logout behavior --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-25 23:35:56 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#931
No description provided.