mirror of
https://github.com/go-shiori/shiori.git
synced 2026-04-25 14:35:52 +03:00
[GH-ISSUE #129] Dragging bookmarlet doesn't work #91
Labels
No labels
component:backend
component:builds
component:builds
component:extension
component:frontend
component:readability
database
database:mysql
database:postgres
database:sqlite
feature:ebooks
github_actions
good first issue
hacktoberfest
note:duplicate?
note:fixed?
note:out-of-scope?
os:windows
priority:high
priority:low
pull-request
resolution:as-intended
resolution:cant-reproduce
resolution:duplicate
resolution:fixed
resolution:wontfix
tag:TBD
tag:big-task
tag:help-wanted
tag:huge-data
tag:meta
tag:more-info
tag:next
tag:no-stale
tag:requires-migrations
tag:research
tag:security 🛡️
tag:stale
tag:waiting-for-assignee
type:bug
type:documentation
type:enhancement
type:meta
type:ux
user:cli
user:web
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shiori#91
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mzch on GitHub (May 1, 2019).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/129
I've added bookmarklet in commit
4b93937. To use it, just drag theAdd new bookmarkbutton to your bookmark toolbar :When possible (i.e. allowed by CSP), the bookmarklet will show dialog for saving new bookmark :
However, if it's not possible, the bookmarklet will redirect you to submit page :
Please try it out.
I don't think I will do it, because :
shiori. Right now I just want to focus on making shiori stable and reliable enough to use.shiori, they usually put it behind a web server anyway, and there are already many good web server that can fetch SSL certificate from Let'sEncrypt, e.g Caddy and nginx.Originally posted by @RadhiFadlillah in https://github.com/RadhiFadlillah/shiori/issues/84#issuecomment-395104974
@mzch commented on GitHub (May 1, 2019):
Hi,
Bookmarklet can’t be dragged to toolbar on Chrome 74.0.3729.108 or later and Safari 12.1.
Is this only my own problem?
@mzch commented on GitHub (May 1, 2019):
Sorry, I found it in About dialog.
@imjoeyli commented on GitHub (Nov 25, 2019):
It doesn't work in Shiori v1.5, I can't drag add button now. How did you solve it?