[GH-ISSUE #129] Dragging bookmarlet doesn't work #91

Closed
opened 2026-02-25 23:33:25 +03:00 by kerem · 3 comments
Owner

Originally created by @mzch on GitHub (May 1, 2019).
Original GitHub issue: https://github.com/go-shiori/shiori/issues/129

I've added bookmarklet in commit 4b93937. To use it, just drag the Add new bookmark button to your bookmark toolbar :

Screencast

When possible (i.e. allowed by CSP), the bookmarklet will show dialog for saving new bookmark :

As dialog

However, if it's not possible, the bookmarklet will redirect you to submit page :

As submit page

Please try it out.


Since you can get a SSL certificate pretty easily and for free through LetsEncrypt, you could maybe integrate auto certificate renewal...

I don't think I will do it, because :

  • It adds new complexity to shiori. Right now I just want to focus on making shiori stable and reliable enough to use.
  • When user self hosted shiori, they usually put it behind a web server anyway, and there are already many good web server that can fetch SSL certificate from Let'sEncrypt, e.g Caddy and nginx.

Originally posted by @RadhiFadlillah in https://github.com/RadhiFadlillah/shiori/issues/84#issuecomment-395104974

Originally created by @mzch on GitHub (May 1, 2019). Original GitHub issue: https://github.com/go-shiori/shiori/issues/129 I've added bookmarklet in commit [`4b93937`](https://github.com/RadhiFadlillah/shiori/commit/4b939379e83b34f6d9d97517a80b8dd44313bbe8). To use it, just drag the `Add new bookmark` button to your bookmark toolbar : ![Screencast](https://user-images.githubusercontent.com/6129042/41046069-e255a74e-69d3-11e8-9723-8fe0f811e168.gif) When possible (i.e. allowed by CSP), the bookmarklet will show dialog for saving new bookmark : ![As dialog](https://user-images.githubusercontent.com/6129042/41046287-5c5a5774-69d4-11e8-8459-bf7a71297e47.png) However, if it's not possible, the bookmarklet will redirect you to submit page : ![As submit page](https://user-images.githubusercontent.com/6129042/41046461-a60c8ac2-69d4-11e8-84af-245a070180f1.png) Please try it out. --- > Since you can get a SSL certificate pretty easily and for free through LetsEncrypt, you could maybe integrate auto certificate renewal... I don't think I will do it, because : - It adds new complexity to `shiori`. Right now I just want to focus on making shiori stable and reliable enough to use. - When user self hosted `shiori`, they usually put it behind a web server anyway, and there are already many good web server that can fetch SSL certificate from Let'sEncrypt, e.g Caddy and nginx. _Originally posted by @RadhiFadlillah in https://github.com/RadhiFadlillah/shiori/issues/84#issuecomment-395104974_
kerem closed this issue 2026-02-25 23:33:25 +03:00
Author
Owner

@mzch commented on GitHub (May 1, 2019):

Hi,

Bookmarklet can’t be dragged to toolbar on Chrome 74.0.3729.108 or later and Safari 12.1.
Is this only my own problem?

<!-- gh-comment-id:488260655 --> @mzch commented on GitHub (May 1, 2019): Hi, Bookmarklet can’t be dragged to toolbar on Chrome 74.0.3729.108 or later and Safari 12.1. Is this only my own problem?
Author
Owner

@mzch commented on GitHub (May 1, 2019):

Sorry, I found it in About dialog.

<!-- gh-comment-id:488346414 --> @mzch commented on GitHub (May 1, 2019): Sorry, I found it in About dialog.
Author
Owner

@imjoeyli commented on GitHub (Nov 25, 2019):

It doesn't work in Shiori v1.5, I can't drag add button now. How did you solve it?

<!-- gh-comment-id:557960104 --> @imjoeyli commented on GitHub (Nov 25, 2019): It doesn't work in Shiori v1.5, I can't drag add button now. How did you solve it?
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#91
No description provided.