[PR #981] [MERGED] fix: --storage-directory flag not being honored in the CLI #908

New issue

Closed

opened 2026-02-25 23:35:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/981
Author: @Monirzadeh
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @fmartingr

Base: master ← Head: fix-storage-directory-flag

📝 Commits (2)

8e2aa20 respect --storage-directory flag fix #980
3d5ab19 Merge branch 'master' into fix-storage-directory-flag

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 internal/cmd/root.go (+1 -1)

📄 Description

fix #980
i don't see anywhere else we set cfg.Storage.DataDir if it has higher priority than --storage-directory than we should change

if storageDirectory != "" && cfg.Storage.DataDir != ""

if storageDirectory != "" && cfg.Storage.DataDir == ""

Closes #980

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/981 **Author:** [@Monirzadeh](https://github.com/Monirzadeh) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix-storage-directory-flag` --- ### 📝 Commits (2) - [`8e2aa20`](https://github.com/go-shiori/shiori/commit/8e2aa201ab64835199235055a9a71e4a1ef93f79) respect --storage-directory flag fix #980 - [`3d5ab19`](https://github.com/go-shiori/shiori/commit/3d5ab1976c62660d2357a07d38c846ea1c157a54) Merge branch 'master' into fix-storage-directory-flag ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `internal/cmd/root.go` (+1 -1) </details> ### 📄 Description fix #980 i don't see anywhere else we set `cfg.Storage.DataDir` if it has higher priority than `--storage-directory` than we should change ``` if storageDirectory != "" && cfg.Storage.DataDir != "" ``` to ``` if storageDirectory != "" && cfg.Storage.DataDir == "" ``` Closes #980 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>