[PR #971] [MERGED] fix: wrong eventBus.js path and non-existant method call #902

New issue

Closed

opened 2026-02-25 23:35:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/971
Author: @fmartingr
Created: 8/27/2024
Status: ✅ Merged
Merged: 8/28/2024
Merged by: @fmartingr

Base: master ← Head: fix/eventbus-path

📝 Commits (4)

d1868a8 fix: eventBus.js path reference
ebae418 fix: non-existant method call
e94a307 Merge branch 'master' into fix/eventbus-path
02d47cc Merge branch 'master' into fix/eventbus-path

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 internal/view/index.html (+1 -1)
📝 internal/view/login.html (+0 -1)

📄 Description

Fixes the path to the eventBus.js file on the index.html file
Fixes the login page calling to an undefined loadSetting method

Closes #962

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/971 **Author:** [@fmartingr](https://github.com/fmartingr) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 8/28/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/eventbus-path` --- ### 📝 Commits (4) - [`d1868a8`](https://github.com/go-shiori/shiori/commit/d1868a8889da7d3a200158f1b8a8198ef4a8df9f) fix: eventBus.js path reference - [`ebae418`](https://github.com/go-shiori/shiori/commit/ebae4182b6deca07ffb07b24641d2ceab885db92) fix: non-existant method call - [`e94a307`](https://github.com/go-shiori/shiori/commit/e94a30764fe09512bf6f5262c20317d3d41047f4) Merge branch 'master' into fix/eventbus-path - [`02d47cc`](https://github.com/go-shiori/shiori/commit/02d47cc9cc8af098eb633c76514314d2cfd714cd) Merge branch 'master' into fix/eventbus-path ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/index.html` (+1 -1) 📝 `internal/view/login.html` (+0 -1) </details> ### 📄 Description - Fixes the path to the `eventBus.js` file on the `index.html` file - Fixes the login page calling to an undefined `loadSetting` method Closes #962 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>