[PR #972] fix: make number of concurrent downloads configurable #901

Open
opened 2026-02-25 23:35:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/972
Author: @Oppen
Created: 8/27/2024
Status: 🔄 Open

Base: masterHead: fix/configurable_concurrency_limits


📝 Commits (3)

  • 555936b fix: make number of concurrent downloads configurable
  • 7f2b185 Merge branch 'master' into fix/configurable_concurrency_limits
  • cba4f84 Typo and nonsensical default

📊 Changes

5 files changed (+21 additions, -12 deletions)

View changed files

📝 docs/Configuration.md (+4 -3)
📝 internal/cmd/check.go (+4 -4)
📝 internal/cmd/update.go (+3 -3)
📝 internal/config/config.go (+7 -0)
📝 internal/http/routes/api/v1/bookmarks.go (+3 -2)

📄 Description

Adds a new environment variable SHIORI_MAX_PAR_DL to limit the number
of concurrent downloads on the update command (and other, if necessary).
It defaults to the number of logical CPUs reported by the Go runtime.

Fixes #966


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/972 **Author:** [@Oppen](https://github.com/Oppen) **Created:** 8/27/2024 **Status:** 🔄 Open **Base:** `master` ← **Head:** `fix/configurable_concurrency_limits` --- ### 📝 Commits (3) - [`555936b`](https://github.com/go-shiori/shiori/commit/555936b96481ec2a1ca82710fbdfc7f631b3d6ef) fix: make number of concurrent downloads configurable - [`7f2b185`](https://github.com/go-shiori/shiori/commit/7f2b185889e1ed05b570c8da9e040f5d59962c0c) Merge branch 'master' into fix/configurable_concurrency_limits - [`cba4f84`](https://github.com/go-shiori/shiori/commit/cba4f84b138ec3f501641b664e7d88187cd98c5a) Typo and nonsensical default ### 📊 Changes **5 files changed** (+21 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `docs/Configuration.md` (+4 -3) 📝 `internal/cmd/check.go` (+4 -4) 📝 `internal/cmd/update.go` (+3 -3) 📝 `internal/config/config.go` (+7 -0) 📝 `internal/http/routes/api/v1/bookmarks.go` (+3 -2) </details> ### 📄 Description Adds a new environment variable `SHIORI_MAX_PAR_DL` to limit the number of concurrent downloads on the `update` command (and other, if necessary). It defaults to the number of logical CPUs reported by the Go runtime. Fixes #966 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shiori#901
No description provided.