[PR #969] [MERGED] fix: temporary files not being deleted #900

New issue

Closed

opened 2026-02-25 23:35:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:35:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/go-shiori/shiori/pull/969
Author: @Oppen
Created: 8/25/2024
Status: ✅ Merged
Merged: 8/28/2024
Merged by: @fmartingr

Base: master ← Head: fix/lingering_tmpfile

📝 Commits (4)

0332518 fix: use os.Remove for tmpFile
0a06379 fix: delete double file remove
7cf1341 Merge branch 'master' into fix/lingering_tmpfile
a8098ad Merge branch 'master' into fix/lingering_tmpfile

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 internal/core/processing.go (+1 -2)

📄 Description

Fixes a path mismatch between a temporary file and its removal.
It also fixes a second removal of the file.

Should fix #966

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-shiori/shiori/pull/969 **Author:** [@Oppen](https://github.com/Oppen) **Created:** 8/25/2024 **Status:** ✅ Merged **Merged:** 8/28/2024 **Merged by:** [@fmartingr](https://github.com/fmartingr) **Base:** `master` ← **Head:** `fix/lingering_tmpfile` --- ### 📝 Commits (4) - [`0332518`](https://github.com/go-shiori/shiori/commit/0332518e46a81c0bf3e75d78b11858cf535bf690) fix: use os.Remove for tmpFile - [`0a06379`](https://github.com/go-shiori/shiori/commit/0a0637997aadef51080e0ceed31cf6f83b78b0e8) fix: delete double file remove - [`7cf1341`](https://github.com/go-shiori/shiori/commit/7cf1341eaa0f8af3b47c31e7d1a3df3f09f71bad) Merge branch 'master' into fix/lingering_tmpfile - [`a8098ad`](https://github.com/go-shiori/shiori/commit/a8098adcd34f72c929c55b0d9635e5aa7eb8fadc) Merge branch 'master' into fix/lingering_tmpfile ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `internal/core/processing.go` (+1 -2) </details> ### 📄 Description Fixes a path mismatch between a temporary file and its removal. It also fixes a second removal of the file. Should fix #966 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>